Make Generated Output in CMake More Robust #4489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `_opendds_*_generated_output functions` in CMake didn't have any sort of testing and could give incorrect results for where to put the export header file. This tries to correct both of those issues. Also added workaround for DOCGroup/ACE_TAO#2202
iguessthislldo
force-pushed
the
igtd/cmake-gen-out
branch
from
16b440d
to
eb3a167
Compare
Now it doesn't have a seperate case for generated directory, but INCLUDE_BASE for the TypeSupport.idl has to be the generated directory, which required some changes.
mitza-oci
approved these changes
Mar 4, 2024
Added `opendds_target_sources(EXPORT_HEADER_DIR)`, `opendds_export_header(DIR)`, and tests for them. Removed the broken `opendds_export_header(INCLUDE_BASE)`.
mitza-oci
reviewed
Mar 6, 2024
mitza-oci
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated output functions in CMake didn't have any sort of testing and could give incorrect results for where to put the export header file. This tries to correct both of those issues.
Also added workaround for DOCGroup/ACE_TAO#2202