OpenDDS cannot be configured with environment variables #4491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iguessthislldo
requested changes
Feb 27, 2024
jrw972
force-pushed
the
env-config
branch
2 times, most recently
from
23b75e0
to
fd5d92a
Compare
iguessthislldo
approved these changes
Feb 29, 2024
jrw972
commented
Mar 1, 2024
| LPTSTR env_string = (LPTSTR) env_strings; | ||
|
|
||
| while (*env_string) { | ||
| parse_env(ACE_TEXT_ALWAYS_CHAR(env_string)); |
There was a problem hiding this comment.
@mitza-oci Does this make sense?
There was a problem hiding this comment.
Try adding a uses_wchar Windows build to CI
There was a problem hiding this comment.
For posterity...
build_and_test.yml is at the limit that GHA will allow so we will need to refactor it before we can add another build.
Converting an existing Windows build failed with build errors. One of the root causes was wide character not being supported correctly for ACE's XML support. So, we will need to be selective about what features to include in such a build.
I will record these points in the Wiki.
jrw972
force-pushed
the
env-config
branch
2 times, most recently
from
11adb2d
to
363b7d2
Compare
mitza-oci
reviewed
Mar 4, 2024
Problem ------- OpenDDS cannot be configured with environment variables. Configuring with environment variables is useful for containers and cloud deployments. Solution -------- Parse environment variables and add them to the ConfigStore. Only environment variables starting with OPENDDS_ are parsed. The remainder of the name is used as the key for the ConfigStore. Environment variables are processed before command-line arguments and the config file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
OpenDDS cannot be configured with environment variables. Configuring with environment variables is useful for containers and cloud deployments.
Solution
Parse environment variables and add them to the ConfigStore. Only environment variables starting with OPENDDS_ are parsed. The remainder of the name is used as the key for the ConfigStore. Environment variables are processed before command-line arguments and the config file.