Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve QoS Documentation #4520

Merged
merged 6 commits into from Mar 18, 2024

Conversation

iguessthislldo
Copy link
Member

  • Quality of Service
    • Rearranged to remove large default value tables.
    • Added Data Representation and Type Consistency Enforcement.
    • Every policy now has a box that says if it's mutable, if it affects writer-reader association, its default values, and links to the spec definition.
    • Added many links to QoS policies
  • Move fnmatch expressions into an "annex" file so it can be common between security and partitions QoS.
  • Add definitions for "instance", "unregister", and "dispose" to the glossary.

- Quality of Service
  - Rearranged to remove large default value tables.
  - Added Data Representation and Type Consistency Enforcement.
  - Every policy now has a box that says if it's mutable, if it affects writer-reader association, its default values, and links to the spec definition.
  - Added many links to QoS policies
- Move fnmatch expressions into an "annex" file so it can be common between security and partitions QoS.
- Add definitions for "instance", "unregister", and "dispose" to the glossary.
@iguessthislldo
Copy link
Member Author

The main change, the info boxes for the QoS, can be seen here https://opendds--4520.org.readthedocs.build/en/4520/devguide/quality_of_service.html#reliability-qos

@iguessthislldo
Copy link
Member Author

docs/devguide/annex.rst Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved

``DURATION_INFINITE_SEC``
When using :ref:`dds_security`, the user data of a participant can be leaked in unsecured discovery messages.
Enabling ``[rtps_discovery]SecureParticipantUserData`` will only send and provide the real user data when it can be securely sent.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks strange in the rendered document. The [rtps_discovery]SecureParticipantUserData should look like it appears in the ini format, or just link to the other section.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what what the rendered config domain links look like. Here is the example RST for the config domain. Right now the links looks the same as the input except for sections discriminators, which appear like [transport] default_address (rtps_udp).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is something we can address in a follow-on PR?

docs/devguide/annex.rst Outdated Show resolved Hide resolved
docs/devguide/conditions_and_listeners.rst Outdated Show resolved Hide resolved
docs/devguide/quality_of_service.rst Outdated Show resolved Hide resolved
docs/devguide/quality_of_service.rst Outdated Show resolved Hide resolved
iguessthislldo and others added 2 commits March 14, 2024 15:44
Co-authored-by: Justin Wilson <wilsonj@unityfoundation.io>
docs/devguide/conditions_and_listeners.rst Outdated Show resolved Hide resolved
docs/devguide/conditions_and_listeners.rst Outdated Show resolved Hide resolved
docs/devguide/xtypes.rst Outdated Show resolved Hide resolved
docs/devguide/quality_of_service.rst Outdated Show resolved Hide resolved
iguessthislldo and others added 2 commits March 18, 2024 04:52
Co-authored-by: Son Dinh <technology789@gmail.com>
@iguessthislldo iguessthislldo merged commit 3286e18 into OpenDDS:master Mar 18, 2024
3 checks passed
@iguessthislldo iguessthislldo deleted the igtd/devguide-qos branch March 25, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants