RtpsUdpDataLink sends nacks when writer has clearly moved on #4548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitza-oci
approved these changes
Mar 28, 2024
iguessthislldo
approved these changes
Mar 29, 2024
Problem ------- When doing interoperability testing, OpenDDS was observed to send a nack for a sequence number that is no longer available. The offending sequence is 1. Writer sends a HB for [X, X]. 2. OpenDDS Reader sends a NACK for X. 3. Writer sends DATA with sequence number X + 1. 4. Writer sends HB for [X+1, X+1]. 5. OpenDDS Reader sends a NACK for X. OpenDDS should treat X as unavailable. Solution -------- The RtpsUdpDataLink contains a code fragment that handles this case but it is limited to the first heartbeat that was received. Move this code out so that it is processed for each heartbeat.
jrw972
force-pushed
the
rtps-udp-datalink-heartbeat-gap
branch
from
0bd70e7
to
cc6d4b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When doing interoperability testing, OpenDDS was observed to send a nack for a sequence number that is no longer available. The offending sequence is
OpenDDS should treat X as unavailable.
Solution
The RtpsUdpDataLink contains a code fragment that handles this case but it is limited to the first heartbeat that was received. Move this code out so that it is processed for each heartbeat.