Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vcpkg to fix a failed download #4557

Closed
wants to merge 1 commit into from

Conversation

mitza-oci
Copy link
Member

No description provided.

@iguessthislldo
Copy link
Member

It looks like it's still trying to download from https://github.com/tukaani-project/xz

Copy link
Member

@iguessthislldo iguessthislldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In microsoft/vcpkg#37839 I think they're saying they reverted the versions, but the xz repo's still gone and they're not going to change the repo. So I think our options are either to patch vcpkg like it seems people are doing or somehow get it to not need xz if that's even possible.

@mitza-oci
Copy link
Member Author

It looks like it's still trying to download from https://github.com/tukaani-project/xz

Right, ce1916404fc6f2b645f419a6d47b7ebafe686582 changed the version back to 5.4.4 but that's apparently insufficient.

We'll need to wait for microsoft/vcpkg#37957

@mitza-oci mitza-oci marked this pull request as draft April 3, 2024 20:20
@mitza-oci
Copy link
Member Author

Or something in the dependency chain has to change... (the identifiers in brackets are enabled features for each package)

qt5-tools
qt5-declarative[platform-default-features, d3d12]
qt5-imageformats[tiff, webp]
tiff[jpeg, lzma, zip]
liblzma

We install "qt5-winextras", "qt5-tools", "qt5-svg", "qt5-multimedia", "qt5-declarative" to satisfy Wireshark's build-time dependencies.

@mitza-oci
Copy link
Member Author

Wireshark's own CI appears to use https://github.com/jurplel/install-qt-action

@jrw972
Copy link
Contributor

jrw972 commented Apr 4, 2024

We can also not build the wireshark ui.

@jrw972
Copy link
Contributor

jrw972 commented Apr 11, 2024

Closed by #4571

@jrw972 jrw972 closed this Apr 11, 2024
@mitza-oci mitza-oci deleted the vcpkg branch April 11, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants