Moved the variable ACE_TAO_OPTION to the packageconfig 'doc-group3' #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The selection to use ACE_TAO version 2 or 3 is is now in the packageconfig 'doc-group3'. Default the version 2 is used. As it is in the configuration of OpenDDS. Although the syntax was correct before, using variables is tainting the global namespace of Yocto. And using a packageconfig is more the yocto way. Signed-off-by: Jan Vermaete <jan.vermaete@gmail.com>
|
@jrw972 If you would like to review? Changes are tested here. The catch why it took longer is that the PACKAGECONFIG option to set doc-group3 has to be done on the native version of the recipe too. I changed the readme file for that. |
jrw972
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rather small PR to change the variable to decide if the docgroup v2 or v3 is used into a package config.
This is a more Yocto way of doing the same.
The selection to use ACE_TAO version 2 or 3 is is now in the packageconfig 'doc-group3'.
Default the version 2 is used. As it is in the configuration of OpenDDS.
Although the syntax was correct before, using variables is tainting the global namespace of Yocto.
And using a packageconfig is more the yocto way.