Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlatformToolset = v110_xp #209

Closed
OlafvdSpek opened this issue Apr 12, 2013 · 20 comments
Closed

PlatformToolset = v110_xp #209

OlafvdSpek opened this issue Apr 12, 2013 · 20 comments
Labels
waiting for feedback

Comments

@OlafvdSpek
Copy link
Contributor

version_vs100.vcxproj doesn't set PlatformToolset, so it defaults to v100 (I think).
opendune_vs100.vcxproj sets PlatformToolset to v110_xp
@glx22
Copy link
Member

glx22 commented Apr 12, 2013

version project doesn't build anything so there's no need to specify the platform toolset. For opendune project it's different as MSVC2012 by default uses MSVC2010 toolset when it loads a v100 project. And in this case it requires MSVC2010 to be installed. That's why I made it use v110_xp if the project is opened with MSVC2012.

@OlafvdSpek
Copy link
Contributor Author

VC is still asking me to update the toolset when I open the project, hence

this suggestion.

Olaf

@glx22
Copy link
Member

glx22 commented Apr 12, 2013

That's strange because there's no platform toolset option for Makefile type projects

@OlafvdSpek
Copy link
Contributor Author

I know, but VC still asks me to upgrade:

------ Update VC++ projects started -------
Updating project 'opendune'...
No update required.
Updating project 'version'...
Configuration 'Debug|Win32': changing Platform Toolset to 'v110' (was
'v100').

========== Update VC++ projects: 1 succeeded, 0 failed, 1 up-to-date

@glx22
Copy link
Member

glx22 commented Apr 15, 2013

I still don't understand why VC even tries to upgrade. VC2012 can open VC2010 projects without upgrading, they use the same format.

@OlafvdSpek
Copy link
Contributor Author

It's about the toolset, this isn't about upgrading the project file format.

Olaf

@glx22
Copy link
Member

glx22 commented Apr 15, 2013

But there's no possibility to even set it using the properties GUI. Makefile type projects don't have a platform toolset setting. So I don't understand why your VC complains about it.

@OlafvdSpek
Copy link
Contributor Author

I don't understand either.
Does yours not complain?
If so, you must have a better VC then me. :p

Olaf

@glx22
Copy link
Member

glx22 commented Apr 15, 2013

There are no complains from my VC, that's why I don't understand why yours complains. And as I already said, it's not possible to set a platform toolset for Makefile type projects as per definition they don't need it.

@OlafvdSpek
Copy link
Contributor Author

What VC are you running?
Would it hurt to set it anyway?

Olaf

@glx22
Copy link
Member

glx22 commented Apr 15, 2013

I use VS Express 2012 for Windows Desktop, but TrueBrain uses the full VS2012 version without complains either. And as I already said, there's no way to set it via the GUI so I don't see why it should be set in the project file.

@miniupnp
Copy link
Contributor

miniupnp commented Apr 2, 2014

I think we can close this issue, as it is not even preventing to compile anything.

miniupnp added a commit to miniupnp/OpenDUNE that referenced this issue Sep 30, 2015
@miniupnp
-Fix(OpenDUNE#209): Fix compilation under MSVC++ express 2010
0334ae9 
remove Platformtoolset so the default one is picked
fixes OpenDUNE#209
@miniupnp
Copy link
Contributor

@glx22 : does my fix work for your VS Express 2012 ? (I have tested with VS Express 2010)
@OlafvdSpek : which Visual Studio version are you using ?

@OlafvdSpek
Copy link
Contributor Author

I'm currently running 2013 and 2015.

@glx22
Copy link
Member

glx22 commented Sep 30, 2015

For me it works, it uses the platform toolset I set via environment variable PlatformToolset (Windows7.1SDK to be precise). Tested with express 2010, express 2012 and community 2015.

@miniupnp
Copy link
Contributor

miniupnp commented Oct 1, 2015

@OlafvdSpek : does my fix work well for you with 2013 and 2015 ?

@OlafvdSpek
Copy link
Contributor Author

I think the 'fix' is right but I don't know how to test it.

I also noticed VC add a space before the closing />, the Git files are missing this space.

@miniupnp
Copy link
Contributor

miniupnp commented Oct 1, 2015

@OlafvdSpek : It is OK if the project build with your Visual Studio(s)
Without the space before /> it is still correct XML and VC has no problem reading the files

@OlafvdSpek
Copy link
Contributor Author

OlafvdSpek commented Oct 1, 2015 via email

miniupnp added a commit to miniupnp/OpenDUNE that referenced this issue Oct 19, 2015
@miniupnp
-Fix: add space before XML /> in VS2010 project files
aaba5cd 
see issue OpenDUNE#209
it will be consistent with Visual Studio 2010 behaviour
@miniupnp
Copy link
Contributor

@OlafvdSpek : is the last patch ok for you ? :)

miniupnp added a commit to miniupnp/OpenDUNE that referenced this issue Oct 23, 2015
@miniupnp
-Fix: add space before XML /> in VS2010 project files
fa9180d 
see issue OpenDUNE#209
it will be consistent with Visual Studio 2010 behaviour
miniupnp added a commit to miniupnp/OpenDUNE that referenced this issue Oct 31, 2015
@miniupnp
-Fix: add space before XML /> in VS2010 project file (continued)
39f1c00 
ImageHasSafeExceptionHandlers element has been forgotten in
OpenDUNE@fa9180d

see issue OpenDUNE#209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
waiting for feedback
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@miniupnp @OlafvdSpek @glx22