PlatformToolset = v110_xp #209

Closed
OlafvdSpek opened this Issue Apr 12, 2013 · 20 comments

Projects

None yet

3 participants

@OlafvdSpek
Contributor

version_vs100.vcxproj doesn't set PlatformToolset, so it defaults to v100 (I think).
opendune_vs100.vcxproj sets PlatformToolset to v110_xp

Member
glx22 commented Apr 12, 2013

version project doesn't build anything so there's no need to specify the platform toolset. For opendune project it's different as MSVC2012 by default uses MSVC2010 toolset when it loads a v100 project. And in this case it requires MSVC2010 to be installed. That's why I made it use v110_xp if the project is opened with MSVC2012.

Contributor

VC is still asking me to update the toolset when I open the project, hence

this suggestion.

Olaf

Member
glx22 commented Apr 12, 2013

That's strange because there's no platform toolset option for Makefile type projects

Contributor

I know, but VC still asks me to upgrade:

------ Update VC++ projects started -------
Updating project 'opendune'...
No update required.
Updating project 'version'...
Configuration 'Debug|Win32': changing Platform Toolset to 'v110' (was
'v100').

========== Update VC++ projects: 1 succeeded, 0 failed, 1 up-to-date

Member
glx22 commented Apr 15, 2013

I still don't understand why VC even tries to upgrade. VC2012 can open VC2010 projects without upgrading, they use the same format.

Contributor

It's about the toolset, this isn't about upgrading the project file format.

Olaf

Member
glx22 commented Apr 15, 2013

But there's no possibility to even set it using the properties GUI. Makefile type projects don't have a platform toolset setting. So I don't understand why your VC complains about it.

Contributor

I don't understand either.
Does yours not complain?
If so, you must have a better VC then me. :p

Olaf

Member
glx22 commented Apr 15, 2013

There are no complains from my VC, that's why I don't understand why yours complains. And as I already said, it's not possible to set a platform toolset for Makefile type projects as per definition they don't need it.

Contributor

What VC are you running?
Would it hurt to set it anyway?

Olaf

Member
glx22 commented Apr 15, 2013

I use VS Express 2012 for Windows Desktop, but TrueBrain uses the full VS2012 version without complains either. And as I already said, there's no way to set it via the GUI so I don't see why it should be set in the project file.

Contributor
miniupnp commented Apr 2, 2014

I think we can close this issue, as it is not even preventing to compile anything.

@miniupnp miniupnp added a commit to miniupnp/OpenDUNE that referenced this issue Sep 30, 2015
@miniupnp miniupnp -Fix(#209): Fix compilation under MSVC++ express 2010
remove Platformtoolset so the default one is picked
fixes #209
0334ae9
Contributor

@glx22 : does my fix work for your VS Express 2012 ? (I have tested with VS Express 2010)
@OlafvdSpek : which Visual Studio version are you using ?

Contributor

I'm currently running 2013 and 2015.

Member
glx22 commented Sep 30, 2015

For me it works, it uses the platform toolset I set via environment variable PlatformToolset (Windows7.1SDK to be precise). Tested with express 2010, express 2012 and community 2015.

Contributor
miniupnp commented Oct 1, 2015

@OlafvdSpek : does my fix work well for you with 2013 and 2015 ?

Contributor

I think the 'fix' is right but I don't know how to test it.

I also noticed VC add a space before the closing />, the Git files are missing this space.

Contributor
miniupnp commented Oct 1, 2015

@OlafvdSpek : It is OK if the project build with your Visual Studio(s)
Without the space before /> it is still correct XML and VC has no problem reading the files

Contributor
@miniupnp miniupnp added a commit to miniupnp/OpenDUNE that referenced this issue Oct 19, 2015
@miniupnp miniupnp -Fix: add space before XML /> in VS2010 project files
see issue #209
it will be consistent with Visual Studio 2010 behaviour
aaba5cd
Contributor

@OlafvdSpek : is the last patch ok for you ? :)

@miniupnp miniupnp added a commit to miniupnp/OpenDUNE that referenced this issue Oct 23, 2015
@miniupnp miniupnp -Fix(#209): Fix compilation under MSVC++ express 2010
remove Platformtoolset so the default one is picked
fixes #209
ca242d7
@miniupnp miniupnp added a commit to miniupnp/OpenDUNE that referenced this issue Oct 23, 2015
@miniupnp miniupnp -Fix: add space before XML /> in VS2010 project files
see issue #209
it will be consistent with Visual Studio 2010 behaviour
fa9180d
@miniupnp miniupnp added a commit that closed this issue Oct 23, 2015
@miniupnp miniupnp -Fix(#209): Fix compilation under MSVC++ express 2010
remove Platformtoolset so the default one is picked
fixes #209
ca242d7
@miniupnp miniupnp closed this in ca242d7 Oct 23, 2015
@miniupnp miniupnp added a commit to miniupnp/OpenDUNE that referenced this issue Oct 31, 2015
@miniupnp miniupnp -Fix: add space before XML /> in VS2010 project file (continued)
ImageHasSafeExceptionHandlers element has been forgotten in
OpenDUNE@fa9180d

see issue #209
39f1c00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment