-Fix (#178): radar scan double-counted some units and missed others #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueBrain
added a commit
that referenced
this pull request
Jan 20, 2013
-Fix (#178): radar scan double-counted some units and missed others
|
It btw still miscounts deviated units, but that might be intentionally. |
|
Making hex editing on Dune 2 .EXE file I tried to remove all part regards array sorting and cycling on exactly g_unitFindCount instead of g_unitFindCount-1 it seems works for original game. Unfortunately I didn't find more room to add another cycle as showed here for opendune c++ code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The radar scan unit count is often wrong in the heat of a battle. A recount is performed in the Unit_Sort function. A unit may be counted a second time at the expense of another if a swap occurred (e.g. unit swapped with a bullet). In addition, the final unit in the find array is not counted.