Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Rewrite: Create a cleaner, more flexible API for IO and processes #117

Merged
merged 3 commits into from Aug 29, 2018

Conversation

scottwittenburg
Copy link
Contributor

So far, only crop is supported for raster and pandas datasets. Other features are missing at the moment as well, including filtering, geo transforms, and dataset writers.

@coveralls
Copy link

Coverage Status

Coverage decreased (-24.8%) to 48.302% when pulling d7c0a05 on api-rewrite into 4737c04 on master.

Copy link
Collaborator

@johnkit johnkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scott, we want to go ahead and merge these changes, even though we know the API will be changing again. FYI once this branch is merged, I'll also be merging my branch with the gaia.show() method.

--john

@scottwittenburg
Copy link
Contributor Author

Sounds fine to me, do you want me to merge it?

@johnkit
Copy link
Collaborator

johnkit commented Aug 29, 2018

Yep, go ahead and merge, Scott. (Or if there's a permission issue, let me and Aashish know.)

@scottwittenburg
Copy link
Contributor Author

I'm just remembering that this would be the first merge to master changing API (and removing much of the functionality), which I think is why I labeled this PR with a WIP. Are we sure we're ready to merge @johnkit and @aashish24?

@aashish24
Copy link
Collaborator

@scottwittenburg I believe if you have tagged the current master as old-master, then yes, please go ahead remove the WIP and merge it into master 👍

@scottwittenburg
Copy link
Contributor Author

Yes, it's tagged master-pre-api-rewrite for future reference. I'll merge this.

@scottwittenburg scottwittenburg changed the title WIP: API Rewrite: Create a cleaner, more flexible API for IO and processes API Rewrite: Create a cleaner, more flexible API for IO and processes Aug 29, 2018
@scottwittenburg scottwittenburg merged commit 8c3c9e1 into master Aug 29, 2018
@scottwittenburg scottwittenburg deleted the api-rewrite branch August 29, 2018 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants