Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version in header shall not be hardcoded in html #4

Closed
skrchnavy opened this issue Mar 12, 2015 · 2 comments
Closed

Version in header shall not be hardcoded in html #4

skrchnavy opened this issue Mar 12, 2015 · 2 comments
Assignees
@mvi-eea-sk
Labels
enhancement
Milestone
ODN v1.0.0

Comments

@skrchnavy
Copy link
Contributor

Currently the version of ODN is displayed in ckanext/odn_theme/templates/header.html so for every ODN release the theme also requires rerelease.

Expected is external configuration from a configuration file (that is not part of the theme).
If such configuration value is not defined, nothing is displayed.
@skrchnavy skrchnavy added this to the ODN v1.0.0 milestone Mar 12, 2015
mvi-eea-sk added a commit that referenced this issue Mar 26, 2015
@mvi-eea-sk
#4 added global ckan.odn_version property - version not hardcoded in …
3123699 
…header.html and about page
mvi-eea-sk added a commit that referenced this issue Mar 26, 2015
@mvi-eea-sk
#4 forgot to commit displaying it in /ckan-admin/config
c309843
mvi-eea-sk added a commit that referenced this issue Mar 26, 2015
@mvi-eea-sk
#4 update of i18n in sk localization
14bf4f0
@mvi-eea-sk mvi-eea-sk assigned mvi-eea-sk and unassigned rskultety Mar 26, 2015
@skrchnavy
Copy link
Contributor Author

Configuration parameter in CKAN configuration file must be added to support this.
ckan.odn_version = 1.0

@skrchnavy skrchnavy reopened this Mar 26, 2015
@skrchnavy skrchnavy mentioned this issue Mar 26, 2015
Merged
@mvi-eea-sk
Copy link
Contributor

OpenDataNode/odn-box@e3d9e51
DONE, closing

@skrchnavy skrchnavy removed the ready label Mar 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvi-eea-sk mvi-eea-sk

Labels
enhancement
Projects
None yet
Milestone
ODN v1.0.0
Development

No branches or pull requests
3 participants
@skrchnavy @mvi-eea-sk @rskultety