Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To split odn-theme plugin into plugins for IC and PC #8

Closed
skrchnavy opened this issue Sep 11, 2015 · 4 comments
Closed

To split odn-theme plugin into plugins for IC and PC #8

skrchnavy opened this issue Sep 11, 2015 · 4 comments
Assignees
@skrchnavy
Labels
enhancement
Milestone
ODN v1.2.0

Comments

@skrchnavy
Copy link
Contributor

Currently we have one common plugin for OpenDataNode theme (odn-theme). It is required to be able to theme both Internal and Public catalog independently, so 2 plugins shall be added (odn-theme-ic and odn-theme-pc).
There is also expected common code, so odn-theme will be presented and those 2 new themes shall only override snippets/templates/css that are different.
@skrchnavy skrchnavy added this to the ODN v1.2.0 milestone Sep 11, 2015
@mvi-eea-sk
Copy link
Contributor

@skrchnavy just to be sure, this new plugins should be part of the same ckan extension like this:

  • ckanext-odn-theme = CKAN extension
    • odn_theme = one of the plugins inside the extension
    • odn_theme_ic = one of the plugins inside the extension
    • odn_theme_pc = one of the plugins inside the extension

In internal catalog, plugins enabled in production.ini will be:

plugins = odn_theme odn_theme_ic ...

In public catalog, plugins enabled in production.ini will be:

plugins = odn_theme odn_theme_pc ...

@skrchnavy
Copy link
Contributor Author

Yes, plugins in same extension and configured in production.ini

mvi-eea-sk added a commit that referenced this issue Sep 11, 2015
@mvi-eea-sk
[#8] theme split for IC and PC
f0de88b 
- each has own plugin: odn_theme_ic, odn_theme_pc
- added template css for each catalog
- displaying actor name in header moved from "base" theme to IC theme plugin
- added change log file
@mvi-eea-sk
Copy link
Contributor

@skrchnavy i split the themes in branch: feature/split_ic_pc_theme
commit: f0de88b

reassign the issue to whoever will do the CSS changes

@mvi-eea-sk mvi-eea-sk assigned skrchnavy and unassigned mvi-eea-sk Sep 11, 2015
@skrchnavy
Copy link
Contributor Author

@rskultety to test/update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skrchnavy skrchnavy

Labels
enhancement
Projects
None yet
Milestone
ODN v1.2.0
Development

No branches or pull requests
2 participants
@skrchnavy @mvi-eea-sk