Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop blank sheets when converting to spreadsheet #1019

Closed
timgdavies opened this issue May 16, 2018 · 11 comments
Closed

Drop blank sheets when converting to spreadsheet #1019

timgdavies opened this issue May 16, 2018 · 11 comments
Labels

Comments

@timgdavies
Copy link
Contributor

When I use convert to spreadsheet for OCDS files, I often have to search through lots of tabs that don't have any data in them to find the sheet I want.

Could we have an option to ignore blank sheets when exporting spreadsheet? This would potentially give a big usability boost to use of the spreadsheet conversion for data checking.

@Bjwebb
Copy link
Member

Bjwebb commented May 18, 2018

This should be fairly straightforward. We may event want to change the default.

@duncandewhurst
Copy link
Contributor

+1 (million)

why didn't I think of asking for this???

@duncandewhurst
Copy link
Contributor

Several users at IODC flagged this an issue, so it would be good if we can get this on the non-sprint priority list.

Could we also drop blank columns from the spreadsheet export?

@robredpath
Copy link
Member

@Bjwebb this is the issue I was looking for earlier!

@Bjwebb
Copy link
Member

Bjwebb commented Oct 9, 2018

So, I've been looking at this today, and I'm fairly sure that I'll get this done tomorrow.

This behaviour was added deliberately, as we thought it might be useful for spreadsheet users to be able to see how "complete" their data is, and fill in extra standard fields in the spreadsheet. Is it useful to retain this functionality behind a commandline flag in flatten-tool? This is fairly easy to do, but no point if its not actually useful. Having multiple options in OCDS CoVE is more work, and the big question would be how to put it in the interface.

Similarly this will by default affect 360 and IATI CoVEs. @stevieflow do we want this same behaviour for those (dropping blank sheets and blank columns)? Technically its quite easy to have different options for different CoVEs if there's a commandline flag. Could be confusing for people though.

@timgdavies
Copy link
Contributor Author

This behaviour was added deliberately, as we thought it might be useful for spreadsheet users to be able to see how "complete" their data is, and fill in extra standard fields in the spreadsheet.

I do think this is still useful: but that the default use-case of analysing the data benefits from dropping the columns that are not filled.

I would suggest:

  • Retain the option with a command line flag;
  • Switch the CoVE default to 'filled columns only';
  • @duncandewhurst announces the change to the standard-discuss mailing list when it is in testing, and before it is in live - and asks anyone who is relying on having all the columns in their output to get in touch;
  • Assuming no-one gets in touch to say having all columns in output is essential, push the change live;
  • If there is interest in having all the columns in output, undertake some brief user research to identify how the UX should work for that - and decide whether or not waiting for that should be a blocker to going live on default = filled columns only.

Bjwebb added a commit to OpenDataServices/flatten-tool that referenced this issue Oct 10, 2018
Bjwebb added a commit to OpenDataServices/flatten-tool that referenced this issue Oct 10, 2018
Bjwebb added a commit to OpenDataServices/flatten-tool that referenced this issue Oct 10, 2018
This will optionally include those columns (from the schema) that don't
have any lines of data.
Bjwebb added a commit to OpenDataServices/flatten-tool that referenced this issue Oct 10, 2018
@Bjwebb
Copy link
Member

Bjwebb commented Oct 10, 2018

Here's a pull request for flatten-tool - OpenDataServices/flatten-tool#241
The cli also defaults to dropping blank columns and sheets. There is a comandline option for the old behaviour.

Here's a dev CoVE instance that uses the relevant flatten-tool branch:
http://1019-no-blank-sheets.dev.cove.opendataservices.coop/

@Bjwebb
Copy link
Member

Bjwebb commented Oct 12, 2018

Thanks @duncandewhurst for posting this to standard-discuss https://groups.google.com/a/open-contracting.org/forum/?utm_medium=email&utm_source=footer#!msg/standard-discuss/Sz6HmrnWVJc/pu5B7f3IBAAJ. Now we wait 2 weeks to see if anyone gets in touch.

Bjwebb added a commit to OpenDataServices/flatten-tool that referenced this issue Oct 15, 2018
odscjames added a commit to OpenDataServices/flatten-tool that referenced this issue Oct 23, 2018
@odscjames
Copy link
Contributor

A new --remove-empty-schema-columns feature in flatten tool will be in the next release, 0.4.0. After discussion with @kindly, we changed how it works. By default, it works as it did so nothing will change. So this will need to be explicitly enabled per site for each site that wants it.

@Bjwebb
Copy link
Member

Bjwebb commented Apr 2, 2019

So, this is now an option in flatten-tool. @duncandewhurst Do we also want to enable this in OCDS CoVE? (Looks like it already is for IATI).

@duncandewhurst
Copy link
Contributor

It's already enabled as the default behaviour in OCDS CoVE too :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants