Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IATI CoVE doesnt sum percentages in decimals #1056

Open
stevieflow opened this issue Sep 25, 2018 · 3 comments
Open

IATI CoVE doesnt sum percentages in decimals #1056

stevieflow opened this issue Sep 25, 2018 · 3 comments

Comments

@stevieflow
Copy link
Member

If you try to include the following:

  <recipient-country code="AF" percentage="25.55" />
  <recipient-country code="AG" percentage="74.45" />

CoVE reports:

recipient-country|recipient-region/@percentage adds up to 0%

eg: http://iati.cove.opendataservices.coop/data/5e3dc9c1-7c48-4dc9-9c14-3fd7191ff44b (with attached)

CoVE doesn't report this error for percentages that are integers

The standard says: http://reference.iatistandard.org/203/activity-standard/iati-activities/iati-activity/recipient-country/

This value must be of type xsd:decimal.

Im unclear as to whether this is just on recipient-country, or also sector

@Bjwebb
Copy link
Member

Bjwebb commented Oct 12, 2018

I don't see an attached file (I think you can't upload an XML file to GitHub issue maybe). Here's a gist with a file that reproduces the issue: https://gist.github.com/Bjwebb/e2e54574dc6fc09803874705dd259809

@Bjwebb
Copy link
Member

Bjwebb commented Oct 12, 2018

This is fixed in #1058, dev branch: http://1056-sum-decimals.dev.cove.opendataservices.coop/

@stevieflow
Copy link
Member Author

Thanks @Bjwebb

I've checked this, and the bug looks to be fixed

@robredpath robredpath moved this from Ideas & Reports to Backlog in IATI CoVE Sprint 2018-10-17 -> 2018-10-30 Oct 16, 2018
@BibianaC BibianaC moved this from Backlog to In Progress in IATI CoVE Sprint 2018-10-17 -> 2018-10-30 Oct 16, 2018
@robredpath robredpath added IATI and removed IATI labels Oct 17, 2018
robredpath added a commit that referenced this issue Nov 7, 2018
[#1056] Sum decimals in IATI rulesets correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants