This repository has been archived by the owner on Dec 20, 2021. It is now read-only.
Use filepath instead of path for Windows support #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drpaneas
suggested changes
Mar 24, 2021
gucio321
reviewed
Mar 24, 2021
Comment on lines
-204
to
+203
| return os.Open(path.Join(mpqDir, mpqName)) //nolint:gosec // Will fix later | ||
| return os.Open(filepath.Join(mpqDir, mpqName)) //nolint:gosec // Will fix later |
There was a problem hiding this comment.
could you also fix this nolint directive; This "Will fix later" is there from very long time 😀 : https://stackoverflow.com/questions/52320708/how-to-handle-gosec-linter-warning-potential-file-inclusion-via-variable
gucio321
approved these changes
Mar 24, 2021
essial
reviewed
Mar 24, 2021
| @@ -72,7 +72,7 @@ type Credits struct { | |||
|
|
|||
| // LoadContributors loads the contributors data from file | |||
| func (v *Credits) LoadContributors() []string { | |||
| file, err := os.Open(path.Join("./", "CONTRIBUTORS")) | |||
| file, err := os.Open(filepath.Join(".", "CONTRIBUTORS")) | |||
essial
approved these changes
Mar 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current build fails to create the
OpenDiablo2directory on Windows without this change.In contrast to
path,path/filepathis OS-aware and handles Windows path separators correctly.