Skip to content
This repository has been archived by the owner on Dec 20, 2021. It is now read-only.

common: generate atlas in y rather than x direction #126

Merged
merged 1 commit into from
Nov 10, 2019
Merged

common: generate atlas in y rather than x direction #126

merged 1 commit into from
Nov 10, 2019

Conversation

mewmew
Copy link
Contributor

@mewmew mewmew commented Nov 10, 2019

This lets us generate atlases that are more "square"ish,
and thus less likely to hit the graphics card boundaries
for texture dimensions.

Fixes #121.

This lets us generate atlases that are more "square"ish,
and thus less likely to hit the graphics card boundaries
for texture dimensions.

Fixes #121.
@mewmew
Copy link
Contributor Author

mewmew commented Nov 10, 2019

Prior to this PR, there were atlases that required a width larger than 8192. After this PR, no atlas requires more than 8192 in either width nor height.

Current set of atlases generated:

create atlas
   totalWidth: 32
   totalHeight: 214
create atlas
   totalWidth: 256
   totalHeight: 2560
create atlas
   totalWidth: 35
   totalHeight: 7680
create atlas
   totalWidth: 15
   totalHeight: 3840
create atlas
   totalWidth: 256
   totalHeight: 2400
create atlas
   totalWidth: 256
   totalHeight: 2400
create atlas
   totalWidth: 178
   totalHeight: 4676
create atlas
   totalWidth: 184
   totalHeight: 4505
create atlas
   totalWidth: 159
   totalHeight: 3660
create atlas
   totalWidth: 159
   totalHeight: 3660
create atlas
   totalWidth: 17
   totalHeight: 4608
create atlas
   totalWidth: 256
   totalHeight: 140
create atlas
   totalWidth: 12
   totalHeight: 3584
create atlas
   totalWidth: 135
   totalHeight: 50
create atlas
   totalWidth: 135
   totalHeight: 50
create atlas
   totalWidth: 256
   totalHeight: 140
create atlas
   totalWidth: 256
   totalHeight: 140
create atlas
   totalWidth: 256
   totalHeight: 140

@essial essial added the Bug Something isn't working label Nov 10, 2019
@essial essial merged commit 09e713b into OpenDiablo2:master Nov 10, 2019
@essial
Copy link
Member

essial commented Nov 10, 2019

Thank you so much!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working
Projects
No open projects
Game Client
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

panic: opengl: width (16384) must be less than or equal to 8192
2 participants