Remove CompileErrorException #1758
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrorException` in DMExpressionBuilder
Also fix a bunch of code style notices
# Conflicts: # DMCompiler/DM/Builders/DMObjectBuilder.cs # DMCompiler/DM/Builders/DMProcBuilder.cs # DMCompiler/DM/Expressions/Binary.cs # DMCompiler/DM/Expressions/Builtins.cs # DMCompiler/DM/Expressions/Constant.cs # DMCompiler/DM/Expressions/Dereference.cs # DMCompiler/DM/Expressions/LValue.cs # DMCompiler/DM/Expressions/Procs.cs
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…tion_removals # Conflicts: # DMCompiler/DM/DMProc.cs # DMCompiler/DM/Expressions/Binary.cs # DMCompiler/DM/Expressions/Builtins.cs # DMCompiler/DM/Expressions/Constant.cs
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
InspectCode found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompileErrorException has been removed, opting to use alternatives over throwing an exception for DM code errors. Since it was marked obsolete this reduces the C# warning count from 179 to 117.
There's a new DMExpression called BadExpression that should be used anytime there was an error while building a DMExpression. The Null DMExpression was often used for this, but now we have something that can differentiate
nullfrom an error.DMExpression code was also cleaned up. It now uses file-scoped namespaces, primary constructors, and are all marked
internal.