Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODM 2.0 - Migration to 18.04, Python 3.6, new features, bug fixes #1156

Merged
merged 31 commits into from Sep 21, 2020

Conversation

pierotofy
Copy link
Member

@pierotofy pierotofy commented Sep 8, 2020

This is a major PR (not ready yet, opening a draft to allow early feedback/contributions) that:

  • Upgrades the target OS to Ubuntu 18.04
  • Upgrades Python to version 3.6
  • Upgrades PDAL/Entwine to the latest release

Tentatively I will also try to upgrade OpenSfM to the newest version, which has many new speed improvements, although it's still in active development, so I might hold off on that for a bit until the codebase stabilizes.

Due to possible breaking changes for some users that run this natively (Python 2 vs Python 3 chaos), this will mark a 2.0 release. I will try my best not to break things and provide a smooth path to upgrade.

🥂

@Saijin-Naib
Copy link
Contributor

Does this warrant a quadratik fund?

@pierotofy
Copy link
Member Author

No need, this is a necessary upgrade.

@pierotofy
Copy link
Member Author

pierotofy commented Sep 11, 2020

Should fix (or at least improve substantially) #1113 and #1090

image

(credits to edt author)

@pierotofy
Copy link
Member Author

Guarantees #1110 will never occur (I couldn't reproduce it, but should be fixed).

@pierotofy
Copy link
Member Author

pierotofy commented Sep 11, 2020

Closes #834

@pierotofy
Copy link
Member Author

Implements #983

@smathermather
Copy link
Contributor

Implements #983

Whoa!

@pierotofy
Copy link
Member Author

pierotofy commented Sep 14, 2020

Implements #897

People can now include a geo.txt file that specifies/overrides the camera center coordinates without having to fiddle with exiftool to set GPS tags.

Format:

EPSG:<code> or <+proj definition>
image_name geo_x geo_y [geo_z] [omega (degrees)] [phi (degrees)] [kappa (degrees)] [horz accuracy (meters)] [vert accuracy (meters)]

Use via --geo <path_to_file>. Works like the --gcp option.

@pierotofy pierotofy changed the title Migration to 18.04, Python 3.6 ODM 2.0 - Migration to 18.04, Python 3.6, new features, bug fixes Sep 14, 2020
@pierotofy
Copy link
Member Author

Image masks support for 3D:

image

image

image

@pierotofy
Copy link
Member Author

Aaand... image masking for orthophotos:

image

@pierotofy
Copy link
Member Author

To add a mask, simply create a new image:

<filename>_mask.JPG (make sure to match the extension, including uppercase/lowercase)

For example, DJI_0018.JPG can have a mask by creating a DJI_0018_mask.JPG file and include that in the list of images.

@Saijin-Naib
Copy link
Contributor

Is it possible to use PNG, BMP, or another lossless image format for the mask?

@pierotofy
Copy link
Member Author

Currently the extension must match that of the input image.

@gastgit
Copy link

gastgit commented Sep 16, 2020

Implements #897

People can now include a geo.txt file that specifies/overrides the camera center coordinates without having to fiddle with exiftool to set GPS tags.

Format:

EPSG:<code> or <+proj definition>
image_name geo_x geo_y [geo_z] [omega (degrees)] [phi (degrees)] [kappa (degrees)] [horz accuracy (meters)] [vert accuracy (meters)]

Use via --geo <path_to_file>. Works like the --gcp option.

Tnx for this new feature!
Can CSV be used or only TXT?

@pierotofy
Copy link
Member Author

Only TXT. But it's easy to convert from CSV.

@pierotofy
Copy link
Member Author

Masks can now use arbitrary extensions (.png, .bmp, .unicorn, .whatever).

@pierotofy
Copy link
Member Author

Adds the --tiles option to generate static tiles, since NodeODM will no longer be in charge of this.

@pierotofy pierotofy marked this pull request as ready for review September 17, 2020 18:51
@pierotofy pierotofy merged commit ef174de into OpenDroneMap:master Sep 21, 2020
@smathermather
Copy link
Contributor

Good! Tested this weekend without issue. Just forgot to update here... . Looks great, installs easily, processes fine with no noticable issues.

pierotofy added a commit that referenced this pull request Sep 21, 2020
ODM 2.0 - Migration to 18.04, Python 3.6, new features, bug fixes

Former-commit-id: ef174de
@pierotofy pierotofy mentioned this pull request Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants