Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix outdated docs for angles in geo file #1612

Merged
merged 1 commit into from
Feb 25, 2023
Merged

fix outdated docs for angles in geo file #1612

merged 1 commit into from
Feb 25, 2023

Conversation

zfb132
Copy link
Contributor

@zfb132 zfb132 commented Feb 25, 2023

According to the question, [issue 1473], [pr 1476] and the following code, the omega, phi, kappa should be replaced to yaw, pitch, roll.

ODM/opendm/geo.py

Lines 39 to 43 in 92cab06

if len(parts) >= 7:
yaw, pitch, roll = [float(p) for p in parts[4:7]]
if math.isnan(yaw) or math.isnan(pitch) or math.isnan(roll):
yaw = pitch = roll = None
i = 7

@pierotofy
Copy link
Member

Good catch, thanks @zfb132 ! 🙏

@pierotofy pierotofy merged commit 22464d8 into OpenDroneMap:master Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants