Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove laspy #1614

Merged
merged 11 commits into from
Mar 2, 2023
Merged

Remove laspy #1614

merged 11 commits into from
Mar 2, 2023

Conversation

HeDo88TH
Copy link
Contributor

@HeDo88TH HeDo88TH commented Mar 1, 2023

Closes #1600

Tested on Linux. The code has been modified to use PDAL instead of Laspy, which has resulted in the elimination of one dependency. However, I was unable to test the code path where the write_extra_dimensions parameter is set to True. @pierotofy, could you kindly provide a test case for this scenario? Thank you!

Please note that the auto-formatter has made some edits to the commands.py file by removing duplicate spaces. Please disregard these changes. The only modification I made was to the rectify method, where I removed the laspy workaround for macOS.

opendm/dem/commands.py Outdated Show resolved Hide resolved
opendm/dem/commands.py Outdated Show resolved Hide resolved
opendm/dem/commands.py Outdated Show resolved Hide resolved
@pierotofy
Copy link
Member

Please note that the auto-formatter [...]

Please disable it and clean up any changes. It makes it difficult to review what actually changed. 🙏

@pierotofy
Copy link
Member

write_extra_dimensions can be removed as a parameter, it's used only for debug. (You'll need to also remove any references to it, e.g. in def run_rectification(**kwargs): and up the call stack).

@HeDo88TH
Copy link
Contributor Author

HeDo88TH commented Mar 2, 2023

write_extra_dimensions can be removed as a parameter, it's used only for debug. (You'll need to also remove any references to it, e.g. in def run_rectification(**kwargs): and up the call stack).

All done 👍

@pierotofy
Copy link
Member

👍

@pierotofy pierotofy merged commit ffa7871 into OpenDroneMap:master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove LASPY
2 participants