-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove laspy #1614
Remove laspy #1614
Conversation
Please disable it and clean up any changes. It makes it difficult to review what actually changed. 🙏 |
|
All done 👍 |
👍 |
Closes #1600
Tested on Linux. The code has been modified to use PDAL instead of Laspy, which has resulted in the elimination of one dependency. However, I was unable to test the code path where the
write_extra_dimensions
parameter is set toTrue
. @pierotofy, could you kindly provide a test case for this scenario? Thank you!Please note that the auto-formatter has made some edits to the
commands.py
file by removing duplicate spaces. Please disregard these changes. The only modification I made was to therectify
method, where I removed the laspy workaround for macOS.