Misc fixes #955
Merged
Misc fixes #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll merge this and if we find anything wrong with it I'll revert it. |
|
👍 |
peddyhh
pushed a commit
to peddyhh/ODM
that referenced
this pull request
Jun 7, 2020
Misc fixes Former-commit-id: 5ad5e22
pierotofy
added a commit
that referenced
this pull request
Sep 21, 2020
Misc fixes Former-commit-id: 5ad5e22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a better error message when a reconstruction cannot be completed, removes the dem-maxangle parameter which is currently unused (point clouds don't have ScanAngleRank information) and pulls in the latest MVE version which implements parallel makescene and fixes #951