Support for image URLs with access tokens #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…path>.jpg?<access token>). Tested with s3 presigned urls and Azure SaS
|
Thank you @pierotofy for developing ODM! |
|
Hi @pierotofy, just wondering if you have plans to publish the updated PyODM to PyPI? (I assume this is not something I can do) I am working with PyODM on docker and my image does not like pip installing from my GitHub fork 🥴 |
|
Just updated it, the latest version is on PyPI (1.5.10). |
|
Thank you! |
OKaluza
added a commit
to AuScalableDroneCloud/WebODM
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a regex to identify access tokens appended to image URLs. If found, the image filename is extracted from the URL accordingly.