Add task ID to expanded list item #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ID is useful to locate the task directory for inspection. Because it is fairly long, it seemed better to keep it relatively low in the list of properties to avoid making the essential information more difficult to read or skim through. Yet placing it above the task output minimizes movement when the console is toggled open. See https://community.opendronemap.org/t/19285
|
Looks good @gonzalo-bulnes, thanks for the PR! |
|
Love this. I've always needed this (forever having work-arounds to get this ID) and I didn't even notice it's addition, so it's nice and low-key. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds the Task ID to the list of properties visible in the expanded list item view of tasks.
Why
This ID is useful to locate the task directory for inspection.
See https://community.opendronemap.org/t/19285
See also https://community.opendronemap.org/t/cleanned-point-cloud-on-webodm/19491/2 for another use case.
Note: The request made sense to me, and I found this was something I could do quickly to get familiar with the project. So I opened this PR opportunistically, without prior discussion (I didn't find any open issues on the topic, nor closed issues that were obviously related). If this is something that's been considered in the past, or that is otherwise known as not desirable, please feel free to close the PR, no hard feelings! 馃檪
Implementation
task.idwas already available in the view.Testing
I don't think this needs automated testing (it
renders without exploding!), what do you think?I tested it manually in "production" with a freshly built Docker image on Linux (screenshot above).
Questions
Other considerations
I think a good addition to this would be a "Copy to clipboard" button next to the ID (like GitHub puts next to the branch name of this PR for example), but that wasn't straightforward enough to add without discussion.