Skip to content

Commit

Permalink
Python: dont install distutils
Browse files Browse the repository at this point in the history 
Signed-off-by: Stephan Raue <stephan@openelec.tv>
  • Loading branch information
@sraue
sraue committed Nov 1, 2014
1 parent 5c461ad commit 2ef78f1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/lang/Python/package.mk
View file
Expand Up @@ -136,7 +136,7 @@ makeinstall_target() {
}

post_makeinstall_target() {
EXCLUDE_DIRS="bsddb curses idlelib lib-tk lib2to3 msilib pydoc_data test unittest"
EXCLUDE_DIRS="bsddb curses idlelib lib-tk lib2to3 msilib pydoc_data test unittest distutils"
for dir in $EXCLUDE_DIRS; do
rm -rf $INSTALL/usr/lib/python*/$dir
done
Expand Down

9 comments on commit 2ef78f1

@nickrout
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this was committed a long time ago, but is there any chance of reverting it? People don't like it http://openelec.tv/forum/128-addons/74426-how-to-install-distutils-removed-in-5-0-required-for-flexget#141561

I am unsure if there might be other repercussions.

@stefansaraev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope. no chance.

@miigotu
Copy link

@miigotu miigotu commented on 2ef78f1 Jun 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I ask what the logic/reasoning for this is? There are quite a bit of things we cannot do because of this commit.

@nickrout
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that the answer is that you should do things the OE way, ie produce a proper addon. Easier said than done, but hopefully possible. I am looking for a suitable python app that has been made into an addon to crib from.

@stefansaraev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this commit reverted, there are quite a bit of things that are broken (we also dont have gcc etc..)

@miigotu
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickrout I think its more along the lines of the missing gcc and devlopment headers required for building python extension modules, and that they want to control more what is installed to minimize bug reports.

If you could install extra software, and you made a bug report about freezing or w/e, how do they know you do not have another service running that is saturating the CPU or memory that is causing the freeze/lag? They also probably get issue spam about missing gcc/headers/other modules. On one hand, from a maintainers/developers point of view, I can understand the logic to tightly control this to avoid these situations and maintain a more universal environment.

The thing that bugs me about it is that command line tools and services that have nothing to do with kodi end up being created as "addons" when they are not kodi addons at all. For example wget, wireless-tools, transmission... these are not kodi addons. They are standard linux tools or unique applications altogether. Kodi addons were meant to extend functionality of Kodi itself.

@furieuxjk
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
That's why I left OpenELEC.

@miigotu
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@furieuxjk I am debating that myself, because even though I understand their position on it, I disagree for the reasons above, and I really want to be able to run more than just Kodi on my Pi2.

I have considered creating a gcc addon, headers addon, and distutils addon, but that seems so silly to me and I would not be inclined to ever update them.

I know that some users faced with this dilemma have moved on to OSMC, with positive reports via sickrage forums/github/irc.

@stefansaraev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, take the general chat somewhere else.

Please sign in to comment.