Pictures - thumbnail generation f.u. since 3.1.2

[VDRrulez]

if automatic thumbnail generation is enabled (which seems to be the default setting), XBMC crashes immediately when you try to browse a directory with "Pictures". This happens with 3.1.2 and current trunk, ION64, Frodo. OE 3.1.1 is OK.

[stefansaraev]

this is likely fixed in 39b7eb8. please test and reopen if not

[VDRrulez]

sorry, no, not fixed
just did a fresh OE build.
crashes when I try to browse an smb share. crashes when I select pictures - addons (with no addons installed). hangs when opening an empty directory on local disk.
works OK when automatic thumbnails are disabled.

[VDRrulez]

and I just don't get it. how do I reopen an issue?

[stefansaraev]

@fritsch & gdb are your best friends then ;)

[stefansaraev]

thanks @VDRrulez for reporting and testing
I can reproduce here (just did a fresh build)
I can confirm that removing packages/mediacenter/xbmc/patches/12.2.0/xbmc-990.26.*-PR2890.patch fixes the issue
@sraue please do git revert 39b7eb8 a2340eb

#2466 and #2460 should still be fine after the revert

[stefansaraev]

@arnova http://sprunge.us/gcGh with xbmc/xbmc#2890 xbmc/xbmc@94817e6 and xbmc/xbmc@fe1856c

EDIT: this is openelec patched, so:

void CBackgroundInfoLoader::Run()
{
  try
  {
    if (m_vecItems.size() > 0)
    {
      OnLoaderStart(); // <<==== BackgroundInfoLoader.cpp:49

      // Stage 1: All "fast" stuff we have already cached
      for (vector<CFileItemPtr>::const_iterator iter = m_vecItems.begin(); iter != m_vecItems.end(); ++iter)
      {
        CFileItemPtr pItem = *iter;

hope it would be useful to you

[arnova]

Working on it :-)

[VDRrulez]

works in Frodo now, still broke in Gotham

[stefansaraev]

thanks for looking into it @arnova
@VDRrulez it has been (temporary) reverted in our frodo

[stefansaraev]

closing this as fixed. thank you all. @sraue for next testing / stable my advice is to not include any more xbmc PRs, I'd like to avoid potential regressions. let's "freeze" and wait for gotham ;)

[MartijnKaijser]

Agreed. Gotham has diverged too much to try back porting patches which likely rely on other patches