New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
projects/imx6: final merge of all changes #3645
Conversation
label = "imx6:red:front"; | ||
max-brightness = <248>; | ||
pwms = <&pwm1 0 50000>; | ||
+ linux,default-trigger = "heartbeat"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
be careful here, that only initialises default-trigger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by that? Any problem I can have with this?
Default trigger is heartbeat so as soon kernel starts led starts blinking. Later from service it is set to default-on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First I think I have mixed that with c code :-)
in C:
int x, y = 5;
will only initialze y to 5, so afterwards calculating with x yields undefinied behaviour. Not sure what dtsi is though.
Edit: Oh, I see it's "linux,default-trigger" <- the complete thing is a var: http://www.cs.fsu.edu/~baker/devices/lxr/http/source/linux/Documentation/powerpc/dts-bindings/gpio/led.txt
very good @vpeter4! |
No more interest for imx6 and openelec? I mean other systems beside cubox-i. |
+1 for Wandboard (Quad Rev. B1 in my case) |
Wandboard support is not integrated to this pull request.
|
I don't have Wandboard so I would prefer second PR for it. |
+1 |
I wait for integration of this, and after I would do a Pull request for Wandboard management. Thank you. |
+1 |
So I see OpenELEC 5.0.2 and still no sign of merging this PR. And I though this will be done after 5.0.0. @sraue: is there any interest of OpenELEC to support more devices based on i.MX6 SoC or not? |
@vpeter4 could you rebase ? Thanks |
@piotrasd: why waste time if not merged anyway. So I should rebase again and again every few days.... |
I'm giving up on this so closing PR. To bad. |
At least a short statement from @sraue should be doable :-( |
Please merge this so OpenELEC may benefit from the additionally support devices. @vpeter4 has done some awesome work here, I have been running his UDOO build for several months already without issues. |
@sraue A statement is needed if you want to have that integrated or not. Shipping and providing another 4 images is a completely different topic and from my POV unlikely to happen. |
what to you mean by the "statement" term ? (french spoken here) |
@xoddark took over my work here: https://github.com/xoddark/OpenELEC.tv/commits/imx6_multi_devices |
I want to make OpenELEC run on the RIoTBoard. I´d like to integrate the needed code, but I´m no kernel/driver programmer and would need some help on what I have to change to make it run. |
You need to use appropriate dtb for kernel 3.14 which is used for imx6 project - in general you can't mix dtb's between different kernel versions. So you have 2 options: use mainline kernel or port required changes to kernel used by openelec. |
Ok then I´ll stick to the mainline kernel since all changes are in there. |
@RadiatorTwo Are you sure that the mainline kernel supports vpu and gpu? |
Please merge this! @vpeter4's work is really cool and running Openelec on the i.mx6 is a really nice thing! I can't understand why this request hasn't been accepted yet |
tested on TBS Matrix v2.1 and CuBox-i4Pro