connman: revert debb37a #4101
Merged
connman: revert debb37a #4101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stefansaraev i am ok if it fixes this issue |
|
it does. tested, but I dont want it in stables, really. there is some shit either in connman, or pydbus, or our settings addon idk, causing "deadlocks" in the past, it could be better after downgrading connman but better be safe than sorry, i we get reports after 6.0 betas, I'll see what I can do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
debb37a broke wifi in wizard / first run. as it doesnt seem to
be intentional, reverting.
ref #4099 (comment)
ref http://openelec.tv/forum/92-openelec-os-settings/75617-turn-wifi-on-during-wizard#138096
this should NOT go to stables, the damage is already done. but I dont want to see the "wizard hangs" reports again, it's too late for 5.x
EDIT: personaly, I dont care for wifi, but we had this in 4.x, and it's supported in our settings addon / wizard, anyway. if we dont auto-enable wifi, the "network" wizard page does not make sense for people who dont have (or don want to use) wired.