Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildsys improvements #4262

Merged
merged 3 commits into from Aug 19, 2015

Conversation

Projects
None yet
4 participants
@stefansaraev
Copy link
Contributor

stefansaraev commented Aug 3, 2015

instead of comparing "timestamps" (package.mk newer than $STAMP and so on), this aims to detect changes by comparing md5 sums of the whole package dir (via md5deep)

this is good for people who need to do huge rebases often (or switching branches back and forth without actualy building).

@stefansaraev

This comment has been minimized.

Copy link
Contributor Author

stefansaraev commented Aug 3, 2015

@sraue
// cc @MilhouseVH this could be useful for you.

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

MilhouseVH commented Aug 3, 2015

Interesting, thanks. This could reduce the number of packages that are rm'd unnecessarily under various circumstances. I'll test this, but for the time being will still rely on timestamps when cleaning packages before a build (need to give more thought how best to use this as part of my process).

@lrusak

This comment has been minimized.

Copy link
Contributor

lrusak commented Aug 3, 2015

If this saves me from automatically rebuilding a bunch of packages when I simply switch branches then yes. I will give it a test.

@stefansaraev

This comment has been minimized.

Copy link
Contributor Author

stefansaraev commented Aug 8, 2015

@lrusak it does.

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

MilhouseVH commented Aug 8, 2015

Seems to be working fine, is the plan to backport this to openelec-6.0, as that's where there should be a big benefit (maybe this will happen automatically once master is merged to openelec-6.0?)

@stefansaraev

This comment has been minimized.

Copy link
Contributor Author

stefansaraev commented Aug 8, 2015

depends on @sraue but yea, the plan is to merge master onto 6.0.

sraue added a commit that referenced this pull request Aug 19, 2015

@sraue sraue merged commit dbac8da into OpenELEC:master Aug 19, 2015

@stefansaraev stefansaraev deleted the stefansaraev:buildsys branch Aug 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.