Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase pre_allocated_buffer to fix buffering issues. #4684

Merged
merged 1 commit into from Feb 10, 2016

Conversation

kevmegforest
Copy link

Also activate verbose procfs for better debugging and setting dynamic settings.

This is useful for people with HDA audio with multichannel analog output that needs special asound.conf.

@chewitt
Copy link
Contributor

chewitt commented Feb 7, 2016

Can you be more explicit on what buffering issues this resolves please. Provide links to forum posts etc. with logs and diagnostics.

@@ -3147,7 +3147,7 @@ CONFIG_SND_DYNAMIC_MINORS=y
CONFIG_SND_MAX_CARDS=32
# CONFIG_SND_SUPPORT_OLD_API is not set
CONFIG_SND_PROC_FS=y
# CONFIG_SND_VERBOSE_PROCFS is not set
CONFIG_SND_VERBOSE_PROCFS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you need that one?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+CONFIG_SND_VERBOSE_PROCFS

Shouldn't this be =y or something?

And what about other platforms (eg. RPi etc.) - is this option relevant there too? Aren't we still maintaining Nvidia_Legacy for the time being?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add it tomorrow also.
For the other platforms, I have no idea if it's important for the
snd-hda-intel module since I don't think it's included in non x86 platform
. But the verbose sound fs can be useful in those too.
On Feb 7, 2016 18:37, "MilhouseVH" notifications@github.com wrote:

In projects/Generic/linux/linux.x86_64.conf
#4684 (comment):

@@ -3147,7 +3147,7 @@ CONFIG_SND_DYNAMIC_MINORS=y
CONFIG_SND_MAX_CARDS=32

CONFIG_SND_SUPPORT_OLD_API is not set

CONFIG_SND_PROC_FS=y
-# CONFIG_SND_VERBOSE_PROCFS is not set
+CONFIG_SND_VERBOSE_PROCFS

+CONFIG_SND_VERBOSE_PROCFS

Shouldn't this be =y or something?

And what about other platforms (eg. RPi etc.) - is this option relevant
there too? Aren't we still maintaining Nvidia_Legacy for the time being?


Reply to this email directly or view it on GitHub
https://github.com/OpenELEC/OpenELEC.tv/pull/4684/files#r52127319.

@lrusak
Copy link
Contributor

lrusak commented Feb 7, 2016

@stefansaraev
Copy link
Contributor

this is ok if you remove CONFIG_SND_VERBOSE_PROCFS

echo 2048 > /proc/asound/card0/pcm0p/sub0/prealloc

maybe immediate fix for your issue. fyi debian and ubuntu kernels set it to 64
1024 should be enough.

@kevmegforest
Copy link
Author

I don't know what's the best way to go.
Removing CONFIG_SND_VERBOSE_PROCFS will not permit to do
echo 2048 > /proc/asound/card0/pcm0p/sub0/prealloc
It will permit to keep the 2048 by default for everyone else if you keep the other change.

The other way around is keeping CONFIG_SND_VERBOSE_PROCFS while keeping the default at 64.

I think it's better to get those 2. More control and info of the sound hardware can't be bad to have around in the kernel. And the 2048 settings doesn't really affect a lot of memory too, while reducing the chance of buffer issues in some setups.

@stefansaraev
Copy link
Contributor

then it's ok to have both.

Also activate verbose procfs for better debugging and setting dynamic settings
@kevmegforest
Copy link
Author

I've added all the changes in all projects just as asked by @MilhouseVH
I've also added the =y which was missing in the original PR.

I think it's done.

lrusak added a commit that referenced this pull request Feb 10, 2016
Increase pre_allocated_buffer to fix buffering issues.
@lrusak lrusak merged commit 2d3b996 into OpenELEC:master Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants