Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soltaro Battery Handling Controller #1075

Merged
merged 37 commits into from Mar 12, 2020
Merged

Soltaro Battery Handling Controller #1075

merged 37 commits into from Mar 12, 2020

Conversation

wgerbl
Copy link
Contributor

@wgerbl wgerbl commented Mar 11, 2020

Please review

wgerbl and others added 30 commits October 18, 2019 11:23
@wgerbl
fix calculation of capacity, adds a config field for module type
bdf4a95
@wgerbl
changes type of control flag channels to boolean channels
8862866
@wgerbl
remoce cell drift recogniton, adds error handling
eb80598
@wgerbl
remove cluster version a, it's not used any longer
ca9ef3d
@wgerbl
Merge branch 'develop' into feature/fix_soltaro
3eb04a1
@wgerbl
Merge branch 'develop' into feature/fix_soltaro
c69f807 
# Conflicts:
#	io.openems.edge.battery.soltaro/src/io/openems/edge/battery/soltaro/ModuleType.java
#	io.openems.edge.battery.soltaro/src/io/openems/edge/battery/soltaro/cluster/versionb/Cluster.java
@wgerbl
removes callbacks, add reducing current if pole temperature gets too …
fce1e28 
…high (not finished)
@wgerbl
fix reset address
71f8a3e
@wgerbl
bms cluster min cell voltage
86d8d55
@wgerbl
Merge branch 'develop' into feature/fix_soltaro
09bd917
@wgerbl
min cell for gridcon
5ec4838
@wgerbl
adds max cell voltage to cluster, formatting issues
be9cb20
@wgerbl
stops discharging in warning state
467a262
@wgerbl
Merge branch 'develop' of https://github.com/OpenEMS/openems into dev…
e30c122 
…elop
@wgerbl
Merge branch 'develop' into feature/limit_discharge_cell_voltage
42603f7 
# Conflicts:
#	io.openems.edge.controller.ess.limitdischargecellvoltage/src/io/openems/edge/controller/ess/limitdischargecellvoltage/state/Warning.java
#	io.openems.edge.controller.ess.limitdischargecellvoltage/test/io/openems/edge/controller/ess/limitdischargecellvoltage/helper/DummyEss.java
@wgerbl
Merge branch 'feature/fix_soltaro' into feature/limit_discharge_cell_…
4afe8c3 
…voltage
@wgerbl
readjust DummyEss, checkstyle
badc698
@sfeilmeier
Merge branch 'develop' into feature/limit_discharge_cell_voltage
5d90aa0
@wgerbl
started implementation changing to soltaro specification
07a9726
@wgerbl
Merge branch 'develop' of https://github.com/OpenEMS/openems into dev…
08f7530 
…elop
@wgerbl
Merge branch 'feature/limit_discharge_cell_voltage' of https://github…
0256c42 
….com/OpenEMS/openems into feature/limit_discharge_cell_voltage
@wgerbl
no message
48f0d07
@wgerbl
Merge branch 'develop' of https://github.com/OpenEMS/openems into dev…
e5c47d3 
…elop
@wgerbl
Merge branch 'develop' of https://github.com/OpenEMS/openems into dev…
1e4c413 
…elop
@wgerbl
Merge branch 'develop' into feature/limit_discharge_cell_voltage
413145f 
# Conflicts:
#	cnf/templates/index.xml
@wgerbl
removes the project for the limitdischarge cell voltage controller an…
7b20f44 
…d moves the classes to the soltaro package, finishes implementation with tests
@wgerbl
corrects channel values for current
d51e607
@wgerbl
Merge branch 'develop' of https://github.com/OpenEMS/openems into dev…
f93117f 
…elop

# Conflicts:
#	doc/modules/ROOT/pages/single_document.adoc
#	io.openems.backend.application/BackendApp.bndrun
#	io.openems.common/src/io/openems/common/OpenemsConstants.java
#	io.openems.edge.application/EdgeApp.bndrun
#	ui/package-lock.json
#	ui/package.json
#	ui/src/app/about/about.component.html
@wgerbl
Merge branch 'develop' into feature/soltaro_battery_handling_controller
9eb42d4
@wgerbl
modify pom
b49c3e8
@wgerbl wgerbl closed this Mar 11, 2020
@wgerbl
Merge branch 'develop' into feature/soltaro_battery_handling_controller
e7a22f4 
# Conflicts:
#	io.openems.edge.application/EdgeApp.bndrun
#	io.openems.edge.battery.soltaro/test/io/openems/edge/battery/soltaro/controller/helper/DummyComponentManager.java
@wgerbl wgerbl reopened this Mar 11, 2020
pooran-c
pooran-c approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@pooran-c pooran-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, This controller would actually replace "limit total cell voltage controller", and does maintain some more battery states.

@sfeilmeier sfeilmeier changed the title Feature/soltaro battery handling controller Soltaro Battery Handling Controller Mar 12, 2020
@sfeilmeier sfeilmeier merged commit d41a70f into develop Mar 12, 2020
@sfeilmeier sfeilmeier deleted the feature/soltaro_battery_handling_controller branch March 12, 2020 18:19
@sfeilmeier sfeilmeier mentioned this pull request Mar 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pooran-c pooran-c pooran-c approved these changes

@sfeilmeier sfeilmeier Awaiting requested review from sfeilmeier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@wgerbl @pooran-c @sfeilmeier