Feature/victron multiplus ess #1819
Open
+4,735
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Simon,
it's really bad luck that we developed a victron driver at the same time. Unfortunately we have two very different versions of an implementation. Both bundles support features which are missing in the other bundle.
The victron bundle is more than a simple driver. it is its own "ecosystem". I tried my very best to merge both bundles together.
Here are an overview of my changes:
Note that there is a generic ESS implementation, e.g. ESS Generic Managed Symmetric. To get an ESS you can use the ESS generic controller and connect it to a batteryinverter and to a battery and you will have full ESS capability. In my opinion we should use this mechanism also on victron. And I think, that you may not have heard of this.
There is one step missing on the integration. We should merge batteryinverter.victron.rw and batteryinverter.victron.ro.
I already wanted to do that, but it took my the whole day to merge our changes in your bundle and to refactor the code. And I fear that this merge will took another day.
Both of us should be able to run their project with the current solution. So it is ok for me.
Due to our parallel work, this change is a massive change of your code. I don't know how to handle this and I hope you'll go easy on me.