Refactor RPC handling #2610
Merged
Refactor RPC handling #2610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed endpoints from ControllerApiBackend (edge --> backend): - UpdateUserLanguage (Threw error NotImplemented) - UpdateUserSettings (Threw error NotImplemented) Added endpoint to RestApi: - queryHistoricTimeseriesEnergyPerPeriod - queryHistoricTimeseriesExportXlxs Co-authored-by: Michael Grill <59126309+michaelgrill@users.noreply.github.com> Reviewed-by: Hueseyin Sahutoglu <34771592+huseyinsaht@users.noreply.github.com>
|
|
michaelgrill
approved these changes
Apr 5, 2024
fanass-dev
pushed a commit
to fanass-dev/openems
that referenced
this pull request
May 6, 2024
Removed endpoints from ControllerApiBackend (edge --> backend): - UpdateUserLanguage (Threw error NotImplemented) - UpdateUserSettings (Threw error NotImplemented) Added endpoint to RestApi: - queryHistoricTimeseriesEnergyPerPeriod - queryHistoricTimeseriesExportXlxs Reviewed-by: Hueseyin Sahutoglu <34771592+huseyinsaht@users.noreply.github.com> Co-authored-by: Michael Grill <59126309+michaelgrill@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed endpoints from ControllerApiBackend (edge --> backend):
Added endpoint to RestApi:
Authored-by: Michael Grill 59126309+michaelgrill@users.noreply.github.com
Reviewed-by: Hueseyin Sahutoglu 34771592+huseyinsaht@users.noreply.github.com