fix: remove ts-strict-ignore for env files and add typing #2683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miettal
commented
Jun 26, 2024
| @@ -21,7 +21,7 @@ export interface Environment { | |||
| readonly docsUrlPrefix: string; | |||
| readonly links: { | |||
|
|
|||
| readonly COMMON_STORAGE: string, | |||
| readonly COMMON_STORAGE: string | null, | |||
There was a problem hiding this comment.
default value is null, so I added null.
miettal
commented
Jun 26, 2024
| readonly SETTINGS_NETWORK_CONFIGURATION: string, | ||
| readonly SETTINGS_ALERTING: string | null, | ||
| readonly SETTINGS_NETWORK_CONFIGURATION: string | null, | ||
| readonly EVCS_CLUSTER: string, |
There was a problem hiding this comment.
there is this attribute on theme.ts. but in this file this attribute is missing. so I added it.
miettal
commented
Jun 26, 2024
| // cf. | ||
| // - tools/docker/ui/root/etc/s6-overlay/s6-rc.d/init-nginx/run | ||
| // - tools/docker/ui/assets/env.template.js | ||
| const window_env = (window as any).env as { [key: string]: string}; |
There was a problem hiding this comment.
window is exsiting variable, but window.env is added by project dependent code. typing is needed.
|
|
lukasrgr
approved these changes
Jun 26, 2024
| readonly SETTINGS_NETWORK_CONFIGURATION: string, | ||
| readonly SETTINGS_ALERTING: string | null, | ||
| readonly SETTINGS_NETWORK_CONFIGURATION: string | null, | ||
| readonly EVCS_CLUSTER: string, |
|
For upstream, is this your way with really strict with lint and typing? You want to drop all ts-strict-ignore? Then it is same as our will. |
sfeilmeier
approved these changes
Jun 26, 2024
|
I share one script. // I only checked this script work in my mac.
and it is sorted by strict mode error number, line numbers for file. I(and We) will mainly focus on the head files of this list initially. Because small changes are easy to review and can be improved little by little but surely. as of 2024.6 0876dce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.