Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daylight Saving Time (DST) #124

Closed
glynhudson opened this issue Oct 21, 2020 · 5 comments
Closed

Daylight Saving Time (DST) #124

glynhudson opened this issue Oct 21, 2020 · 5 comments
Assignees
@jeremypoulter
Labels
enhancement New feature or request

Comments

@glynhudson
Copy link
Collaborator

DST needs to be implemented for regions that unfortunately needs to deal with DST. Could this be done automatically based on NTP country selection? Or maybe it's easier to implement with a simple check box for 'enable DST'?
@glynhudson glynhudson added the enhancement New feature or request label Oct 21, 2020
@jeremypoulter
Copy link
Collaborator

It should be as far as I am aware... Although - it may not updated the EVSE, may just be the ESP...

@glynhudson
Copy link
Collaborator Author

Ah interesting, was DST implemented as part of NTP? I assumed the NTP will return unix time

@jeremypoulter
Copy link
Collaborator

Yeah, DST should have been built into the time zone selection, as in if you select Europe/London it should be also applying the DST hour so GMT+1

@jeremypoulter
Copy link
Collaborator

This looked to have worked ok for me, did you see any issues?

@glynhudson
Copy link
Collaborator Author

Yes, I can confirm DST is already implemented! It worked perfectly for me at the weekend. Nice work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeremypoulter jeremypoulter

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glynhudson @jeremypoulter