Mqtt reworked API version #379

KipK · 2022-06-11T13:49:45Z

Fixes #358
Fixes #376
Fixes #373

Following previous discussion here #369
Based on espidf4 branch.

Edit: all functional

jeremypoulter · 2022-06-15T22:11:10Z

I haven't forgotten about this PR, just trying to fix a few issues with #207

mqtt: publish max_current mqtt charge_current/set + max_current/set

mqtt: removed /manual_override/set /pilot/set mqtt: added /override & /claim + related setter ( /override/set [json] | delete | toggle && /claim/set [json] | delete ) m event: publishing new event override containing either json or 0.

…ne (instead of 0)

mqtt: changed delete method to clear/release

…: /claim/set/charge_current, /override/set/state )

fix typo updated doc

KipK · 2022-06-16T22:26:41Z

I need some helps on this one.
I'd like to integrate real time update of modified values on mqtt instead of the 30sec loop pushing the whole dataset.
For ex, "pilot" value should be notified when setting a charge_current override or claim. waiting 30 sec for feedback is inconvenient.
Also publishing the whole dataset each time is spamming the smart home solution database unnecessarily.

Where should I start ?
event_send(data) is already modified to push event to mqtt.
What would be the best way to solve those missing event notifications ?
This also would allow to remove the 5s status fetch on http interface, using only the web socket. ( I was wondering why 2 communication channels here? )
This will will prolly involve also this #376

jeremypoulter · 2022-06-17T02:24:56Z

Just calling event_send should be all you need. That will then send the new values.

The double polling/web socket is just a legacy thing, going to remove the polling at some point.

- removed independent property settable topics. - merge claim properties with previous one when updating a claim/override - clear a property by sending "clear" as parameter ( /claim/set {"charge_current": "clear" }

KipK · 2022-06-20T11:39:00Z

Latest commit remove bulky settables, now merged props is ok.

mqtt: some cleanup

mqtt: publish max_current mqtt charge_current/set + max_current/set

jeremypoulter · 2022-06-26T17:17:23Z

2/ publish everything has "retained", and push only updated data as soon as they have changed. ( need point 3 ). Current implementation spam smart home solution database uselessly.

Possibly this could be an option, may need to be optional though, maybe more relevant for the values that are not evented every 30 seconds, but mostly they where targeted at the HTTP/WS API, IE you get the initial state via the /status endpoint then updates are sent via the WebSocket.

3/ remove the 30sec loop, we need a better event driven status system to publish data when a value has changed. some values like "pilot" are not evented taking too long to update on MQTT side. This will also allows to remove the status polling on the web ui. . I have no idea of the change involved, I'd rather let you guys taking care of this one. I'm still blurry with the main codebase.

The 30 second loop is needed as the values are not evented from the EVSE module, guess we could keep a record of the last value and only send when they change. This may need to also be optional as so use cases it is good to get the regular updates, ie to make sure the device is still online.

This will also allows to remove the status polling on the web ui.

This could be removed already, there may a few bugs, where values may not be evened, but sure these can be resolved. In reality this will probably just not be done when doing a new UI.

I would raise a separate ticket for each of these.

jeremypoulter

Code changes look good, will give it a test then can be merged.

KipK · 2022-06-26T18:44:39Z

The 30 second loop is needed as the values are not evented from the EVSE module, guess we could keep a record of the last value and only send when they change. This may need to also be optional as so use cases it is good to get the regular updates, ie to make sure the device is still online.

On MQTT we already have the last will message to know if the device is connected or not so that shouldn't be a problem. Also we could add an heartbeat somewhere.

KipK · 2022-06-29T21:37:01Z

Can you first merge the current_shaper pull request before this one ?
I will then add the mqtt retain setting. Can't merge it now, I have too much conflicts from my branch with booth :)

mqtt retain setting fixes updated web_static

KipK · 2022-06-30T10:06:20Z

Can you first merge the current_shaper pull request before this one ? I will then add the mqtt retain setting. Can't merge it now, I have too much conflicts from my branch with booth :)

Forget it, I've merged it anyway.
It also needs OpenEVSE/openevse_wifi_gui#80

…into mqtt_ispedfv4

KipK · 2022-07-15T16:16:51Z

Do you plan to merge those soon ?
Maintaining 2 branches for those pull requests and a third one with booth, for my usage, is getting somehow confusing. :)

jeremypoulter · 2022-07-15T17:23:50Z

@KipK really sorry, yes, definitely intended on reviewing/merging this as soon as #350 is complete but I have to focus on that as it is now blocking sales in the UK

…into mqtt_ispedfv4

src/app_config.cpp

src/mqtt.cpp

removed config_changed(_mqtt)

KipK · 2022-07-28T12:25:45Z

this 0b3c212 works even better than the polling.

jeremypoulter

Gave this a test, looks good, just one open query

jeremypoulter · 2022-07-28T21:15:37Z

src/evse_monitor.cpp

+        StaticJsonDocument<128> event;
+        event["pilot"] = _pilot;
+        event_send(event);
+


Is this what you mean? did you intend this to be an event_send for voltage? That being said the voltage is not read by most OpenEVSEs, normally the voltage is a static value or read from MQTT, so eventing it maybe does not make sense

jeremypoulter

Think this is good to go, would at least be good to get it out there for wider comments. Thank you very much for your contribution, it is really appreciated

KipK · 2022-07-29T14:57:59Z

You're welcome. I'm laying around. There's also a pull request for the gui related to this one.

mikebaz and others added 15 commits June 16, 2022 23:09

Huzzah board button press note

6765738

Fixed broken/hi-jacked url from openevse.org to openevse.com

efbfbc1

mqtt: manual_override/set ( start/stop/delete )

39478b6

mqtt: publish max_current mqtt charge_current/set + max_current/set

mqtt: completed documentation

c7dee3e

mqtt: completed documentation

8bf6427

mqtt: changed charge_current/set to /pilot/set

2ca45e3

mqtt: added EvseClient_OpenEVSE_MQTT, EvseManager_Priority_MQTT

6eecef4

created mqtt.md

a03cf7b

mqtt doc typo

e73b05f

WIP: Rework mqtt to follow new api

2ed4e50

mqtt: removed /manual_override/set /pilot/set mqtt: added /override & /claim + related setter ( /override/set [json] | delete | toggle && /claim/set [json] | delete ) m event: publishing new event override containing either json or 0.

temporary fix scheduler / divert mode priority problem

b8f3fe5

mqtt: publish {"state": "null"} to /override & /claim when there's no…

83eac31

…ne (instead of 0)

fix typo ( status vs state )

412aeca

mqtt: updated doc

2241b28

mqtt: changed delete method to clear/release

mqtt: added separated properties set commands for claim/override ( ex…

f031028

…: /claim/set/charge_current, /override/set/state )

KipK force-pushed the mqtt_ispedfv4 branch from 8f13590 to f031028 Compare June 16, 2022 21:12

mqtt: clear global EvseProperties object after clear/release

6e89a66

fix typo updated doc

mqtt:

214ceec

- removed independent property settable topics. - merge claim properties with previous one when updating a claim/override - clear a property by sending "clear" as parameter ( /claim/set {"charge_current": "clear" }

KipK added 8 commits June 20, 2022 22:19

added "pilot" to event update from _evseState

7c85ab5

mqtt: some cleanup

mqtt: manual_override/set ( start/stop/delete )

58d6832

mqtt: publish max_current mqtt charge_current/set + max_current/set

mqtt: completed documentation

c933056

mqtt: completed documentation

1d56162

mqtt: changed charge_current/set to /pilot/set

c4cd101

mqtt: added EvseClient_OpenEVSE_MQTT, EvseManager_Priority_MQTT

026641a

created mqtt.md

f9acd20

mqtt doc typo

c6a031a

jeremypoulter reviewed Jun 26, 2022

View reviewed changes

KipK mentioned this pull request Jun 26, 2022

MQTT manual modes , also Reorganising MQTT topics #373

Closed

fix merge

a9feafb

mqtt retain setting fixes updated web_static

KipK mentioned this pull request Jun 30, 2022

Mqtt: add a checkbox to set mqtt retain flag OpenEVSE/openevse_wifi_gui#80

Merged

KipK added 3 commits July 6, 2022 14:56

Merge branch 'master' of https://github.com/OpenEVSE/ESP32_WiFi_V4.x …

eb0f54d

…into mqtt_ispedfv4

fix merge

987a681

updated gui

a821acf

KipK added 3 commits July 17, 2022 14:26

mqtt: polling rapi each 2 sec to fasten data feedback.

4295d81

mqtt: limiting values that needs to be updated each 2 sec

057d3d1

Merge branch 'master' of https://github.com/OpenEVSE/ESP32_WiFi_V4.x …

739cca6

…into mqtt_ispedfv4

jeremypoulter reviewed Jul 27, 2022

View reviewed changes

src/app_config.cpp Outdated Show resolved Hide resolved

src/app_config.cpp Outdated Show resolved Hide resolved

src/mqtt.cpp Outdated Show resolved Hide resolved

KipK added 3 commits July 28, 2022 09:51

replace bool by ConfigOptVirtualBool

0af3f11

removed config_changed(_mqtt)

remove mqtt 2sec loop

948c1b7

replace some web_server_event() by event_send() to push on mqtt too.

2dcd333

KipK force-pushed the mqtt_ispedfv4 branch from 2813a07 to 2dcd333 Compare July 28, 2022 11:34

add an event when setting pilot & voltage in evse_monitor

0b3c212

jeremypoulter reviewed Jul 28, 2022

View reviewed changes

fix typo

181ad7a

jeremypoulter approved these changes Jul 29, 2022

View reviewed changes

jeremypoulter merged commit 29e6a19 into OpenEVSE:master Jul 29, 2022

KipK deleted the mqtt_ispedfv4 branch July 29, 2022 19:25

glynhudson mentioned this pull request Aug 4, 2022

Home Assistant intergration #246

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mqtt reworked API version #379

Mqtt reworked API version #379

KipK commented Jun 11, 2022 •

edited

jeremypoulter commented Jun 15, 2022

KipK commented Jun 16, 2022 •

edited

jeremypoulter commented Jun 17, 2022

KipK commented Jun 20, 2022 •

edited

jeremypoulter commented Jun 26, 2022 •

edited

jeremypoulter left a comment

KipK commented Jun 26, 2022

KipK commented Jun 29, 2022 •

edited

KipK commented Jun 30, 2022

KipK commented Jul 15, 2022

jeremypoulter commented Jul 15, 2022

KipK commented Jul 28, 2022

jeremypoulter left a comment

jeremypoulter Jul 28, 2022

jeremypoulter left a comment

KipK commented Jul 29, 2022

Mqtt reworked API version #379

Mqtt reworked API version #379

Conversation

KipK commented Jun 11, 2022 • edited

jeremypoulter commented Jun 15, 2022

KipK commented Jun 16, 2022 • edited

jeremypoulter commented Jun 17, 2022

KipK commented Jun 20, 2022 • edited

jeremypoulter commented Jun 26, 2022 • edited

jeremypoulter left a comment

Choose a reason for hiding this comment

KipK commented Jun 26, 2022

KipK commented Jun 29, 2022 • edited

KipK commented Jun 30, 2022

KipK commented Jul 15, 2022

jeremypoulter commented Jul 15, 2022

KipK commented Jul 28, 2022

jeremypoulter left a comment

Choose a reason for hiding this comment

jeremypoulter Jul 28, 2022

Choose a reason for hiding this comment

jeremypoulter left a comment

Choose a reason for hiding this comment

KipK commented Jul 29, 2022

KipK commented Jun 11, 2022 •

edited

KipK commented Jun 16, 2022 •

edited

KipK commented Jun 20, 2022 •

edited

jeremypoulter commented Jun 26, 2022 •

edited

KipK commented Jun 29, 2022 •

edited