-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenEVSE GUI #51
OpenEVSE GUI #51
Conversation
This is the rapiSender class from @lincomatic, with minor changes. Cleans up all of the rapi code quite a lot, with the small caveat that it puts the serial delay in the main loop.
Helps pick up errors as code is been written and can be used to help auto review code.
…nto OpenEVSE_GUI # Conflicts: # src/data/config.js # src/data/home.htm
…v2.x into OpenEVSE_GUI # Conflicts: # src/emonesp.h # src/input.cpp # src/web_server.cpp # src/wifi.cpp
Cleans up all of the rapi code quite a lot, with the small caveat that it puts the serial delay in the main loop.
…v2.x into OpenEVSE_GUI # Conflicts: # src/RapiSender.cpp # src/RapiSender.h # src/wifi.cpp
…nto OpenEVSE_GUI # Conflicts: # src/RapiSender.cpp # src/data/config.js # src/data/home.htm # src/input.cpp # src/web_server.cpp
Added a version that takes a String for convenience and flash string to help save memory.
…v2.x into OpenEVSE_GUI
…v2.x into OpenEVSE_GUI
…v2.x into OpenEVSE_GUI
Few other little issues
|
Setting charger, time limit and charge limit all seems to work great. This is awesome! 👍 Few more minor things I notice on the UI. Would you prefer me to open issues or continue to post here for issues regarding the GUI?
For the benefit of other devs, this is what the GUI looks like so far: |
Here is fine, just put the check boxes so I can track them. |
* I'm not sure if 'Disable' button is needed? Does it do anything more than Sleeping @chris1howell<https://github.com/chris1howell> ?
Disable will stop charging and send the station to an error start (pilot to negative DC)
Sleep will stop sharging and send station to a not ready to provide power (pilot to positive DC)
From the User Interface, I would say only Sleep is needed.
On Thu, Jul 27, 2017 at 12:40 PM, Jeremy Poulter <notifications@github.com<mailto:notifications@github.com>> wrote:
Would you prefer me to open issues or continue to post here for issues regarding the GUI?
Here is fine, just put the check boxes so I can track them.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#51 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABvYH6TUevrZiVD81k04AQyuswUmfDLnks5sSOeQgaJpZM4OhprD>.
|
Yes, the lack of update is related to lincomatic/open_evse#65 |
I think this should be broken out in to a new issue of generally improving the initial setup. I don't think it is specifically related to the OpenEVSE GUI |
It was felt it was to easy to disable safetly tests with the switches on the GUI so these have been hidden. The switches can be re-enabled using developer mode. Developer mode (currently) enables (shows) the RAPI tab and switches to enable/disable test
I can't reproduce this can you give more details, log, .elf file? What state is the EV in? |
…le them. This allows floating left/right to eat up all the space.
I managed to fix this, however all the elements in the Charge Options are always shown rather than being hidden. vs The fundamental problem is the combination of the different size blocks and trying to keep the right hand blocks near the top when in a single column. There does not look to be a CSS only way to do this. The only reasonable way to get the desired effect is to use a JS library like masonry, but that had issues with the tabs and needs some more extensive re-work of the UI. The other option is to do something similar to emonESP and have all the content of the right hand side shift to under all the left hand side content. |
Just tested, layout looks much better now. Not nearly as much whitespace |
These are the changes to add a GUI for OpenEVSE, see #34.
This following features have been implemented;