-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev edfi changes/v0.1 #323
Merged
genegc
merged 27 commits into
OpenEducationAnalytics:main
from
EdWire:dev-edfi-changes/v0.1
Nov 10, 2023
Merged
Dev edfi changes/v0.1 #323
genegc
merged 27 commits into
OpenEducationAnalytics:main
from
EdWire:dev-edfi-changes/v0.1
Nov 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes are highlighted in the */Ed-Fi/notebook/README.md
cviddenKwantum
requested changes
Sep 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See code comments and please revise.
1) API Urls to be fetched via a python notebook 2) Corresponding notebook referenced 3) Dependent changes on the pipeline 4) OEA_py indentation correction
Adding support for custom resource group name
…nEduAnalytics into dev-edfi-changes/v0.1
This commit also ensures that the edfi_py and edfi_fetch_url notebooks are also installed by the setup bash script
…nEduAnalytics into dev-edfi-changes/v0.1
1. Debugged bugs hindering runs of codes 2. Made changes to pipeline orchestration to correctly pass parameters 3. Made changes to the edfi landEntity utility to work with test data as well (when no prod data is provided)
Inclusion of LastModifiedDate is under testing - for now, included within try / except clause
Reverting to CRLF line carriage return
…nEduAnalytics into dev-edfi-changes/v0.1
cviddenKwantum
approved these changes
Nov 2, 2023
cviddenKwantum
approved these changes
Nov 2, 2023
cviddenKwantum
approved these changes
Nov 10, 2023
v-chadvidden
approved these changes
Nov 10, 2023
v-chadvidden
approved these changes
Nov 10, 2023
genegc
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Team,
This branch has relevant commits to improve the Ed-Fi Module.
Please note that OEA base functions like upsert, overwrite, append, add_to_lake_db have also been modified to enable the implementation of the above changes.
For more details,
Warm Regards,
Viraj Jayant
(Representing Edwire)