Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev edfi changes/v0.1 #323

Merged
merged 27 commits into from
Nov 10, 2023
Merged

Conversation

vir-neenopal
Copy link
Contributor

@vir-neenopal vir-neenopal commented Sep 22, 2023

Hi Team,

This branch has relevant commits to improve the Ed-Fi Module.

Please note that OEA base functions like upsert, overwrite, append, add_to_lake_db have also been modified to enable the implementation of the above changes.

For more details,

  1. Kindly refer to the README.md file in */Ed-Fi/notebook/
  2. For EdFi_Refine notebook - kindly read the comments and acknowledgements added at the top of the notebook

Warm Regards,
Viraj Jayant
(Representing Edwire)

Copy link
Collaborator

@cviddenKwantum cviddenKwantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See code comments and please revise.

framework/synapse/notebook/OEA_py.ipynb Outdated Show resolved Hide resolved
vir-neenopal and others added 19 commits October 10, 2023 11:10
1) API Urls to be fetched via a python notebook
2) Corresponding notebook referenced
3) Dependent changes on the pipeline
4) OEA_py indentation correction
Adding support for custom resource group name
This commit also ensures that the edfi_py and edfi_fetch_url notebooks are also installed by the setup bash script
1. Debugged bugs hindering runs of codes
2. Made changes to pipeline orchestration to correctly pass parameters
3. Made changes to the edfi landEntity utility to work with test data as well (when no prod data is provided)
Inclusion of LastModifiedDate is under testing - for now, included within try / except clause
@vir-neenopal
Copy link
Contributor Author

vir-neenopal commented Oct 27, 2023

@genegc genegc merged commit 5bce496 into OpenEducationAnalytics:main Nov 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants