Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how items are sorted #1188

Open
huss opened this issue Apr 3, 2024 · 0 comments
Open

how items are sorted #1188

huss opened this issue Apr 3, 2024 · 0 comments
Labels
i-good-first-issue This issue is probably a good starting point for people new to coding or the OED project. p-low-priority t-enhancement This issues tracks a potential improvement to the software
Milestone

Comments

@huss
Copy link
Member

huss commented Apr 3, 2024

Is your feature request related to a problem? Please describe.

src/client/app/redux/api/unitsApi.ts sorts by ‘accent’ and other places that do localeCompare(). src/client/app/redux/selectors/uiSelectors.ts and other uses sortBy() without this. May be other places that sort that should be looked at.

Describe the solution you'd like

OED should be consistent. Determine what localeCompare might be adding and use as appropriate. One thought is to use a standard callback something like:
sortByIdentifier(entityA,entityB) => localeCompare(...)

Describe alternatives you've considered

The difference probably isn't too important so leave as is until fixed.

Additional context

None

@huss huss added t-enhancement This issues tracks a potential improvement to the software p-low-priority i-good-first-issue This issue is probably a good starting point for people new to coding or the OED project. labels Apr 3, 2024
@huss huss added this to the 1.x milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i-good-first-issue This issue is probably a good starting point for people new to coding or the OED project. p-low-priority t-enhancement This issues tracks a potential improvement to the software
Projects
None yet
Development

No branches or pull requests

1 participant