Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standardize how graphics get language aware times #1194

Open
huss opened this issue Apr 3, 2024 · 0 comments
Open

standardize how graphics get language aware times #1194

huss opened this issue Apr 3, 2024 · 0 comments
Labels
i-good-first-issue This issue is probably a good starting point for people new to coding or the OED project. p-low-priority t-enhancement This issues tracks a potential improvement to the software
Milestone
1.x

Comments

@huss
Copy link
Member

huss commented Apr 3, 2024

Is your feature request related to a problem? Please describe.

Different parts of the code seem to use different methods to get date aware labeling. Two for hover text are:

  • src/client/app/components/ThreeDComponent.tsx uses moment (dateTS.format(moment.localeData().longDateFormat('L').replace(/YYYY/g, 'YY'))).
  • src/client/app/redux/selectors/lineChartSelectors.ts uses timeReading.format('ddd, ll LTS')

There may be other ways in other places.

Describe the solution you'd like

OED should decide the best way and consistently use that (maybe by centralizing the code).

Describe alternatives you've considered

Leave as is but the format may vary.

Additional context

None
@huss huss added t-enhancement This issues tracks a potential improvement to the software p-low-priority i-good-first-issue This issue is probably a good starting point for people new to coding or the OED project. labels Apr 3, 2024
@huss huss added this to the 1.x milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
i-good-first-issue This issue is probably a good starting point for people new to coding or the OED project. p-low-priority t-enhancement This issues tracks a potential improvement to the software
Projects
None yet
Milestone
1.x
Development

No branches or pull requests
1 participant
@huss