Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maps handling negative values better #1205

Open
huss opened this issue Apr 4, 2024 · 0 comments
Open

maps handling negative values better #1205

huss opened this issue Apr 4, 2024 · 0 comments
Labels
i-good-first-issue This issue is probably a good starting point for people new to coding or the OED project. p-low-priority t-bug The issue is related to an aspect of the software which is incorrect
Milestone

Comments

@huss
Copy link
Member

huss commented Apr 4, 2024

Describe the bug

Originally, OED did not have negative readings but it is now allowed. If you place a negative value on a map, you see no circle. If you place the cursor over the expected location you see the correct hover. This screenshot shows this:

image

The issue is likely that src/client/app/containers/MapChartContainer.ts finds the max size where it should probably use the max - min size or something like this.

Another option might be to use another visual for negative (lines through color circle or something else) so it is clear to the user that some values are negative. This would be combined with fixing the actual size.

If others have thoughts about the look then please state them. The ideas here would have larger negative values have smaller circles.

To Reproduce

Steps to reproduce the behavior (assuming you have the usual developer testData loaded):

  1. Create a new meter where the important values are:

image

  1. Place these values in a CSV file for the readings:

reading,start time,end time
-10,2023-01-01 00:00:00,2024-01-01 00:00:00

and do a CSV Readings upload where you specify the meter (from step 1), header row and refresh the daily/hourly readings, along with the CSV created in this step.
3. Go to the map and graph this meter.
4. Place cursor over Library to see

Note the provided CSV reading value is a constant -10 across all of 2023. It could be modified to get other values. If you want to place a circle in another location, looking at the location/GPS value for the amp meters will help.

Expected behavior

The circle size should be visible and scale with usage.

Additional context

None

@huss huss added t-bug The issue is related to an aspect of the software which is incorrect p-low-priority i-good-first-issue This issue is probably a good starting point for people new to coding or the OED project. labels Apr 4, 2024
@huss huss added this to the 1.x milestone Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i-good-first-issue This issue is probably a good starting point for people new to coding or the OED project. p-low-priority t-bug The issue is related to an aspect of the software which is incorrect
Projects
None yet
Development

No branches or pull requests

1 participant