Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

floating point reading data #357

Closed
huss opened this issue Nov 6, 2018 · 2 comments
Closed

floating point reading data #357

huss opened this issue Nov 6, 2018 · 2 comments
Assignees
Labels
p-high-priority This issue should be the focus of design and developement effort.

Comments

@huss
Copy link
Member

huss commented Nov 6, 2018

Initially OED only read pulse meters that returned integer values. The current database stores these readings as int. As we expand devices, we need to accept floating point values. The database needs to be converted to do this. The hope is the changes to the code will be minimal. As part of this process we need to decide on the floating point datatype to use (32-bit vs 64-bit accuracy) and also migrate all current data to the new format.

@huss huss added the p-high-priority This issue should be the focus of design and developement effort. label Nov 6, 2018
@huss huss added this to the 0.6 Release milestone Apr 7, 2020
@huss huss modified the milestones: 0.6 Release, 1.0 Release Apr 7, 2020
@huss
Copy link
Member Author

huss commented Apr 7, 2020

Once we begin accepting data from non-MAMAC sources, we need to have this feature to preserve the data values. We certainly need by release 1.0 but maybe sooner.

@huss huss removed this from the 1.0 Release milestone May 3, 2020
@huss huss self-assigned this May 3, 2020
@huss
Copy link
Member Author

huss commented May 3, 2020

I was looking at the code and noticed that src/server/migrations/0.3.0-0.5.0/sql/readings/set_reading_type_to_real.sql altered the reading table to be floating point. I have done very limited testing but floating point values do graph that way. Thus, this issue seems solved unless someone sees an issue in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-high-priority This issue should be the focus of design and developement effort.
Projects
None yet
Development

No branches or pull requests

2 participants