Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review result to oemetadata #1358 #1368

Draft
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

mdvcode
Copy link
Collaborator

@mdvcode mdvcode commented Sep 15, 2023

Summary of the discussion

This pull request addresses the issue of applying review results to the OEMetadata resource. Once a review is complete, any field in the metadata with a newValue is updated. The key changes introduced are:

  • Writing the new values back to the OEMetadata JSON.

Type of change (CHANGELOG.md)

Added

  • Add a new functionality (#)

Updated

  • Update existing functionality (#)

Removed

  • Remove a broken link (#)

Workflow checklist

Automation

Closes #1358

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@mdvcode mdvcode linked an issue Sep 15, 2023 that may be closed by this pull request
1 task
@mdvcode mdvcode changed the title function of saving metadata in the database #1358 review result to oemetadata #1358 Sep 15, 2023
@jh-RLI jh-RLI marked this pull request as draft November 3, 2023 15:41
jh-RLI added a commit that referenced this pull request Dec 6, 2023
jh-RLI added a commit that referenced this pull request Dec 6, 2023
…iew-remove-future-code-implementation-not-finished

Remove code that is part of #1368 and should not be implemented already
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OPR] Apply review result to oemetadata ressource (update metadata)
3 participants