Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature fix missing ontologies in docker #1631

Conversation

ebroda
Copy link
Contributor

@ebroda ebroda commented Mar 20, 2024

Summary of the discussion

As of #1622 the docker-image is currently missing the oeo. This PR adds a command to the Dockerfile to create the folder, download the latest oeo from github and extract it. So the oeo is correctly included in the Docker image. Afterwards, #1622 is fixed (in connection with #1627).

Also the docker readme is extended to include the docker build command to create the image on your own (if you e.g. change stuff).

Type of change (CHANGELOG.md)

Updated

  • Include oeo in oeplatform docker image (#1631)

Workflow checklist

Automation

Closes #1622

PR-Assignee

Reviewer

  • 馃悪 Follow the Reviewer Guidelines
  • 馃悪 Provided feedback and show sufficient appreciation for the work done

Copy link
Contributor

@jh-RLI jh-RLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't unzip something that needs to be installed first? Maybe we should use the tar.gz

@ebroda
Copy link
Contributor Author

ebroda commented Mar 20, 2024

Isn't unzip something that needs to be installed first? Maybe we should use the tar.gz

Unzip is included in the base image, no need to install it.

$ docker exec -ti docker-oep_oeplatform_1 bash
root@d82c2ffcae71:/app# unzip -v
UnZip 6.00 of 20 April 2009, by Debian. Original by Info-ZIP.
...

Copy link
Contributor

@jh-RLI jh-RLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case the PR looks good.

@jh-RLI jh-RLI merged commit b3ae08c into OpenEnergyPlatform:develop Mar 20, 2024
2 checks passed
@ebroda ebroda deleted the feature-fix-missing-ontologies-in-docker branch March 21, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starting oeplatform from Docker fails
2 participants