Fixes for recommendations/requirements from #38 and issue #92 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p code. Will add more documentation soon.
…to issue-92 and rebuilt js.
…jshint. Rebuilt js.
…passed to the listeners. For example, when binding to F2.Constants.AppHandlers.APP_RENDER, it looks like an appConfig and maybe a string of html that represents the app" and "List the order in which the events are executed. This should either be done in the sdk or the spec and linked to each other" from 1.2-wip pull request OpenF2#69
…t executes immediately which in turn resolved tests not running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixes in this branch are for recommendations/requirements for #38 that ultimately were discussed in #92.
Should completely resolve:
[ ] Update sdk documentation to explain what is passed to the listeners. For example, when binding to F2.Constants.AppHandlers.APP_RENDER, it looks like an appConfig and maybe a string of html that represents the app
[ ] Fix errors reported by JS Hint when the shadow option is disabled
And partially resolve (sans spec updates):
[ ] List the order in which the events are executed. This should either be done in the sdk or the spec and linked to each other
from #69.
Let me know if you have any questions or concerns.