Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppHandler APP_DESTROY_AFTER exists and so does "RESOURCE_FAILED_TO_LOAD" #222

Closed
markhealey opened this issue Jan 13, 2015 · 4 comments
Closed
Milestone

Comments

@markhealey
Copy link
Member

I can't recall why there are multiple things happening on errors like this (and in other places) but this should be cleaned up.

In container.js, both of these are fired when a script fails to load:

F2.Events.emit('RESOURCE_FAILED_TO_LOAD', evtData);
...
_appScriptLoadFailed(appConfigs[0], evtData.src);

If nothing else, the former should be added to the F2.Constants.Events object. Let's mark RESOURCE_FAILED_TO_LOAD for deprecation.

@markhealey markhealey added this to the 1.4.0 milestone Jan 13, 2015
@markhealey
Copy link
Member Author

@montlebalm you wanna grab this since you were just in #220? After thinking some more on it, we need to keep that RESOURCE_FAILED_TO_LOAD event around and definitely mark it for deprecation.

Surprisingly, the docs have no mention of this event being fired in the life cycle which also needs to be addressed.

@markhealey
Copy link
Member Author

Also just noticed this new event APP_SCRIPTS_LOADED is not in Constants but is well-documented.

https://github.com/OpenF2/F2/blob/1.4-wip/docs/src/container-development.md#when-are-scripts-loaded

Let's add it to Constants, too.

@montlebalm
Copy link
Member

@markhealey Sure I'll take this one.

@markhealey
Copy link
Member Author

Closed #227 in #142 v1.4.0

brianbaker added a commit that referenced this issue Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants