Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F2.registerPreLoadedApps should add classNames to root element (1.2-wip) #88

Closed
colinStevenson opened this issue May 2, 2013 · 3 comments
Milestone

Comments

@colinStevenson
Copy link

When calling F2.registerPreLoadedApps - I would expect the appropriate F2-app classNames to be added to the root element.

@ghost ghost assigned Ali-Khatami May 3, 2013
@Ali-Khatami
Copy link
Contributor

@brianbaker , @markhealey - Feel free to assign this to me, if you can. I'll hopefully take care of this later today.

@markhealey
Copy link
Member

@Ali-Khatami, you're all set. Remember to keep your commit small (no compiled stuff in the wip). Thanks.

@brianbaker brianbaker mentioned this issue May 9, 2013
24 tasks
@markhealey
Copy link
Member

After some discussion around this, we've decided the Container Developer--not F2.js--should append the AppId as the classname on the outer-most HTML element when using preloaded apps. The end result should be similar to what F2 produces via the traditional method of loading apps as documented in the Namespacing part of the spec.

<div class="f2-app-container com_companyName_appName">
    ...
</div>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants