Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AeroDyn WriteOutput linearization (and cleanup some code) #1061

Merged
merged 11 commits into from Sep 20, 2022

Conversation

bjonkman
Copy link
Contributor

@bjonkman bjonkman commented Mar 23, 2022

This PR can be merged after #1042.

Feature or improvement description
This pull request primarily cleans up some of the AeroDyn code (and its submodules) to better sync with the Envision AeroDyn code base. It also addresses an issue where the WriteOutput values in AeroDyn were not updated in linearization (after multi-rotor capability was added).

  • AeroAcoustics

    • removed unused variables
    • made exponents integer numbers instead of reals where appropriate (to make the math faster/more accurate)
    • updated subroutine arguments to pass arrays of AFI(:) instead of AFI(:)%BL_File. At least some versions of the gcc compiler do not handle the arrays properly the way they were previously written.
    • substituted numeric value of 2 with equivalent parameter X_BLMethod_Tables where appropriate
    • converted print * statements with calls to WrScr()
  • AeroDyn

  • VS Build

    • AeroDyn driver solution now warns for unused variables in Debug configuration.

Related issue, if one exists
#972

Impacted areas of the software
AeroDyn, linearization with AeroDyn WriteOutputs

Test results, if applicable
I would expect this to get the same test results as #1042.

@bjonkman bjonkman changed the title F/aero sync Fix AeroDyn WriteOutput linearization (and cleanup some code) Mar 24, 2022
@rafmudaf rafmudaf added this to the v3.3.0 milestone Apr 7, 2022
@rafmudaf rafmudaf added this to In progress in v3.4.0 Apr 7, 2022
@rafmudaf rafmudaf modified the milestones: v3.4.0, v3.3.0 Sep 20, 2022
@rafmudaf rafmudaf removed this from In progress in v3.4.0 Sep 20, 2022
@rafmudaf rafmudaf added this to In progress in v3.3.0 via automation Sep 20, 2022
@rafmudaf
Copy link
Collaborator

@bjonkman #1042 was merged so this one can go next. Could you merge dev into this branch?

@rafmudaf
Copy link
Collaborator

@bjonkman #1042 was merged so this one can go next. Could you merge dev into this branch?

Well that was good timing. Thanks!

@rafmudaf rafmudaf merged commit ef6d6ba into OpenFAST:dev Sep 20, 2022
v3.3.0 automation moved this from In progress to Done Sep 20, 2022
@bjonkman bjonkman deleted the f/Aero_Sync branch September 20, 2022 17:47
@rafmudaf rafmudaf mentioned this pull request Oct 27, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants