New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AeroDyn WriteOutput linearization (and cleanup some code) #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- some outputs weren't calculated for both FVW and BEMT but could be (merged into one subroutine) - also adds a couple of variables to help sync with Envision
bjonkman
changed the title
F/aero sync
Fix AeroDyn WriteOutput linearization (and cleanup some code)
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR can be merged after #1042.
Feature or improvement description
This pull request primarily cleans up some of the AeroDyn code (and its submodules) to better sync with the Envision AeroDyn code base. It also addresses an issue where the WriteOutput values in AeroDyn were not updated in linearization (after multi-rotor capability was added).
AeroAcoustics
AFI(:)
instead ofAFI(:)%BL_File
. At least some versions of the gcc compiler do not handle the arrays properly the way they were previously written.2
with equivalent parameterX_BLMethod_Tables
where appropriateprint *
statements with calls toWrScr()
AeroDyn
rTipFix
to sync better with Envision code base (will update its usage later)VS Build
Debug
configuration.Related issue, if one exists
#972
Impacted areas of the software
AeroDyn, linearization with AeroDyn WriteOutputs
Test results, if applicable
I would expect this to get the same test results as #1042.