Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename FAST to OpenFAST in source #116

Merged
merged 15 commits into from
Jun 13, 2018

Conversation

rafmudaf
Copy link
Collaborator

@rafmudaf rafmudaf commented May 15, 2018

This pull request selectively renames occurrences of "FAST" to "OpenFAST" in order to more accurately reflect the transition from FAST 8.16 to OpenFAST v1.0.0.

The following occurrences have been renamed

  • Messages to the user printed through stdout (the console)
  • Print statements in the results files
  • Compiled executable and binary names
  • High level source code file names

The following occurrences have not been renamed

  • Low level source code file like module names, function names, errors, etc
  • The FAST Registry
  • Anything in modules-ext

The code in pull request #107 have been incorporated here, so thanks to @ NobuhiroKUSUNO for the help. Also, this pull request is a dependency of #105.

@rafmudaf rafmudaf self-assigned this May 15, 2018
@rafmudaf
Copy link
Collaborator Author

Please see the regression test results below for this pull request. Of note is the there is an existing bug in the BeamDyn unit tests, beamdyn_utest, which causes it to fail inconsistently. This bug will be addressed in a coming pull request, but I reran that particular test after the full regression test to show that it is buggy and should not reflect the validity of the code requested to merge here.

mbp@~/Development/openfast/build: ctest -j 30
Test project /Users/rmudafor/Development/openfast/build
      Start  1: AWT_YFix_WSt
      Start  2: AWT_WSt_StartUp_HighSpShutDown
      Start  3: AWT_YFree_WSt
      Start  4: AWT_YFree_WTurb
      Start  5: AWT_WSt_StartUpShutDown
      Start  6: AOC_WSt
      Start  7: AOC_YFree_WTurb
      Start  8: AOC_YFix_WSt
      Start  9: UAE_Dnwind_YRamp_WSt
      Start 10: UAE_Upwind_Rigid_WRamp_PwrCurve
      Start 11: WP_VSP_WTurb_PitchFail
      Start 12: WP_VSP_ECD
      Start 13: WP_VSP_WTurb
      Start 14: WP_Stationary_Linear
      Start 15: SWRT_YFree_VS_EDG01
      Start 16: SWRT_YFree_VS_EDC01
      Start 17: SWRT_YFree_VS_WTurb
      Start 18: 5MW_Land_DLL_WTurb
      Start 19: 5MW_OC3Mnpl_DLL_WTurb_WavesIrr
      Start 20: 5MW_OC3Trpd_DLL_WSt_WavesReg
      Start 21: 5MW_OC4Jckt_DLL_WTurb_WavesIrr_MGrowth
      Start 22: 5MW_ITIBarge_DLL_WTurb_WavesIrr
      Start 23: 5MW_TLP_DLL_WTurb_WavesIrr_WavesMulti
      Start 24: 5MW_OC3Spar_DLL_WTurb_WavesIrr
      Start 25: 5MW_OC4Semi_WSt_WavesWN
      Start 26: 5MW_Land_BD_DLL_WTurb
      Start 27: bd_5MW_dynamic
      Start 28: bd_curved_beam
      Start 29: bd_isotropic_rollup
      Start 30: bd_static_cantilever_beam
 1/32 Test #28: bd_curved_beam ...........................   Passed    2.51 sec
 2/32 Test #29: bd_isotropic_rollup ......................   Passed    2.59 sec
      Start 31: bd_static_twisted_with_k1
      Start 32: beamdyn_utest
 3/32 Test #14: WP_Stationary_Linear .....................   Passed    3.80 sec
 4/32 Test #30: bd_static_cantilever_beam ................   Passed    3.92 sec
 5/32 Test #31: bd_static_twisted_with_k1 ................   Passed    1.55 sec
 6/32 Test #32: beamdyn_utest ............................***Failed    1.65 sec
 7/32 Test  #1: AWT_YFix_WSt .............................   Passed   86.06 sec
 8/32 Test  #6: AOC_WSt ..................................   Passed  121.47 sec
 9/32 Test #27: bd_5MW_dynamic ...........................   Passed  134.74 sec
10/32 Test #11: WP_VSP_WTurb_PitchFail ...................   Passed  144.03 sec
11/32 Test #12: WP_VSP_ECD ...............................   Passed  149.13 sec
12/32 Test  #2: AWT_WSt_StartUp_HighSpShutDown ...........   Passed  154.79 sec
13/32 Test  #3: AWT_YFree_WSt ............................   Passed  175.20 sec
14/32 Test  #8: AOC_YFix_WSt .............................   Passed  183.90 sec
15/32 Test  #5: AWT_WSt_StartUpShutDown ..................   Passed  214.77 sec
16/32 Test #22: 5MW_ITIBarge_DLL_WTurb_WavesIrr ..........   Passed  246.82 sec
17/32 Test #10: UAE_Upwind_Rigid_WRamp_PwrCurve ..........   Passed  270.74 sec
18/32 Test #13: WP_VSP_WTurb .............................   Passed  329.55 sec
19/32 Test #24: 5MW_OC3Spar_DLL_WTurb_WavesIrr ...........   Passed  374.76 sec
20/32 Test  #9: UAE_Dnwind_YRamp_WSt .....................   Passed  379.37 sec
21/32 Test #23: 5MW_TLP_DLL_WTurb_WavesIrr_WavesMulti ....   Passed  386.02 sec
22/32 Test  #4: AWT_YFree_WTurb ..........................   Passed  427.37 sec
23/32 Test  #7: AOC_YFree_WTurb ..........................   Passed  448.15 sec
24/32 Test #16: SWRT_YFree_VS_EDC01 ......................   Passed  448.72 sec
25/32 Test #18: 5MW_Land_DLL_WTurb .......................   Passed  457.10 sec
26/32 Test #15: SWRT_YFree_VS_EDG01 ......................   Passed  559.13 sec
27/32 Test #25: 5MW_OC4Semi_WSt_WavesWN ..................   Passed  572.61 sec
28/32 Test #19: 5MW_OC3Mnpl_DLL_WTurb_WavesIrr ...........   Passed  701.70 sec
29/32 Test #17: SWRT_YFree_VS_WTurb ......................   Passed  804.78 sec
30/32 Test #26: 5MW_Land_BD_DLL_WTurb ....................   Passed  831.41 sec
31/32 Test #20: 5MW_OC3Trpd_DLL_WSt_WavesReg .............   Passed  1327.76 sec
32/32 Test #21: 5MW_OC4Jckt_DLL_WTurb_WavesIrr_MGrowth ...   Passed  2189.54 sec

97% tests passed, 1 tests failed out of 32

Label Time Summary:
aerodyn14    = 2209.90 sec*proc (7 tests)
aerodyn15    = 9778.79 sec*proc (19 tests)
beamdyn      = 976.73 sec*proc (6 tests)
dynamic      = 134.74 sec*proc (1 test)
elastodyn    = 11157.28 sec*proc (25 tests)
hydrodyn     = 5799.22 sec*proc (7 tests)
map          = 1007.60 sec*proc (3 tests)
moordyn      = 572.61 sec*proc (1 test)
openfast     = 11988.69 sec*proc (26 tests)
servodyn     = 11984.88 sec*proc (25 tests)
static       =  10.58 sec*proc (4 tests)
subdyn       = 4219.01 sec*proc (3 tests)

Total Test time (real) = 2189.76 sec

The following tests FAILED:
	 32 - beamdyn_utest (Failed)
Errors while running CTest
mbp@~/Development/openfast/build: ctest -R beamdyn_utest
Test project /Users/rmudafor/Development/openfast/build
    Start 32: beamdyn_utest
1/1 Test #32: beamdyn_utest ....................   Passed    0.05 sec

100% tests passed, 0 tests failed out of 1

Total Test time (real) =   0.06 sec

@rafmudaf
Copy link
Collaborator Author

rafmudaf commented May 17, 2018

@jjonkman @ghaymanNREL @michaelasprague Please let me know if you have any feedback regarding the updated naming that I've added here. I chose to avoid renaming every instance of "fast" to "openfast" in order to prevent any unnecessary bugs since modules and subroutine names contain "fast". Furthermore, I'd like to minimize introducing breaking changes for anyone using OpenFAST as a dll like @gantech.

Copy link
Collaborator

@jjonkman jjonkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to NWTC_IO.f90/CheckArgs() are not universal. This routine is used not only by OpenFAST, but many other related programs including standalone drivers, TurbSim, etc.

The first problem is that "IF ( NumArg .EQ. 0 ) THEN" has been added to display the syntax. But this message should not be displayed if the program accepts a DefaultInputFile.

The second problem is that statements have been added regarding restart/checkpoint files, but these statements only apply to OpenFAST, not to other programs that may use this SUBROUTINE.

You may need to make a custom CheckArgs routine for OpenFAST (but this then should probably not be included in the NWTC Subroutine Library).

Everything else in this pull request is OK.

@rafmudaf rafmudaf force-pushed the feature/fast_becomes_openfast branch 2 times, most recently from 7a2e9ec to 6f679e3 Compare June 8, 2018 00:51
@rafmudaf
Copy link
Collaborator Author

rafmudaf commented Jun 8, 2018

@jjonkman I've reverted the portions of this pull request which you pointed out were incorrect. Rather than squeezing it in here, I'll leave issue #105 open for now. Please review again and let me know if you find anything else. And thanks for the feedback.

@rafmudaf rafmudaf mentioned this pull request Jun 8, 2018
Copy link
Collaborator

@jjonkman jjonkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were lines 2659-2661 removed from NWTC_IO.f90?

The other changes look fine with me.

This subroutine is generic and should support main programs which allow for a default input file. In that case, NumArgs is 0 but it is not an error.
@rafmudaf rafmudaf force-pushed the feature/fast_becomes_openfast branch from 6f679e3 to b8bcbdd Compare June 8, 2018 15:46
@rafmudaf
Copy link
Collaborator Author

rafmudaf commented Jun 8, 2018

@jjonkman that was a mistake, thank you for catching that. I've added those lines back in the latest commit.

Copy link
Collaborator

@jjonkman jjonkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments.

@rafmudaf rafmudaf removed the request for review from HaymanConsulting June 8, 2018 16:15
Copy link
Contributor

@michaelasprague michaelasprague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@rafmudaf rafmudaf merged commit 798ca6a into OpenFAST:dev Jun 13, 2018
@rafmudaf rafmudaf deleted the feature/fast_becomes_openfast branch June 13, 2018 20:57
rafmudaf added a commit that referenced this pull request Jun 13, 2018
* rename glue-codes/fast to glue-codes/openfast

* update gitiginore

* remove the version from fast registry

* Rename CMake utilities

* Rename the cpp glue code

* rename fast registry to openfast registry

* rename fast-library to openfast-library

* Update r-test submodule and add new beamdyn specific test

* Documentation updates for fast to openfast name change

* Bug fix in displaying the program name

* Get naming updates from the r-test submodule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants