Add linearization regression tests #2038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 5MW_Land_BD_Linear_Aero: BD + AD15 (based on 5MW_Land_BD_Linear, but with aero) - 5MW_Land_Linear_Aero: ED + AD15 (based on 5MW_Land_BD_Linear_Aero, but with ED) - 5MW_OC4Semi_MD_Linear: MD equivalent of 5MW_OC4Semi_Linear
deslaughter
approved these changes
Feb 16, 2024
Specify using np.float32 where possible in reading the linearization file. Also use np.float64 instead of float for matrices. Read matrices with genfromtxt instead of line by line
Previously the number of parallel threads in CTest was set via the -j flag. This changes it to use an environment variable set at the top of the file. The number of parallel tests was reduced from 4 to 2 as the linearization tests were failing from lack of memory. This may need to be adjusted.
…sion tests. The previous method looped over each element and checked to see if it was within tolerance of the reference. This does the compare for the full matrices and then iterates over the element indices which were not within tolerance. This should significantly reduce the time to do the comparison for large matrices. Also prints out the row/column variables which correspond to that element.
This will prevent warnings about node 16 deprecation
…SS_Rdtn%numStates This also moves to a simpler scheme that just checks if the perturbation index 'n' is equal to the current value index 'k'
bjonkman
pushed a commit
to bjonkman/openfast
that referenced
this pull request
Feb 20, 2024
…unstable Merge rc-3.5.3 into dev-unstable-pointers (this is to get PR OpenFAST#2038)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs review of results before merging.
Feature or improvement description
The number of linearization cases has been somewhat limited and did not fully cover the code. This PR adds the following regression tesrts:
5MW_Land_BD_Linear_Aero-- based on the5MW_Land_BD_Linearcase, but with the addition of aero damping5MW_Land_Linear_Aero-- based on5MW_Land_BD_Linear_Aero, but with ElastoDyn for the blades5MW_OC4Semi_MD_Linear-- based on5MW_OC4Semi_MD_Linear, but with MoorDyn instead of MAP5MW_OC3Spar_Linear-- a very simple linearization of the5MW_OC3Spar_DLL_WTurb_WavesIrrcase with no aero, no controls, and no inflow.Related issue, if one exists
None.
Impacted areas of the software
Regression tests cover aero and more hydro for comparisons during glue-code reorganization.
Additional supporting information
During the development of the tight-coupling (for OF v5.0), the linearization must be refactored from the implementation in v3.5 and v4.0. It has proven difficult to check that all the modules are correctly implemented in the new code without linearization models that included aero.
Test results, if applicable
Test results below.