Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to setup-python@v4 and cache@v4 for GH actions #2041

Merged

Conversation

andrew-platt
Copy link
Collaborator

@andrew-platt andrew-platt commented Feb 16, 2024

This should be ready to merge

Feature or improvement description
GitHub upgraded the actions to use node.js 20 instead of node.js 16. We were getting deprecation warnings like:

Screenshot 2024-02-16 at 11 29 16 AM

https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

Fixing this requires updating two packages we use in testing:

  • actions/setup-python@v3 --> actions/setup-python@v5
  • actions/cache@v3 --> actions/cache@v4

For actions/setup-python, version 5.0.0 uses the new node 20 (see actions/setup-python#735)

Impacted areas of the software
Automated testing through GitHub actions only

@andrew-platt andrew-platt added this to the v3.5.3 milestone Feb 16, 2024
@andrew-platt andrew-platt self-assigned this Feb 16, 2024
Copy link
Contributor

@deslaughter deslaughter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be nice to not have all those warnings

@deslaughter deslaughter merged commit 53b5f9f into OpenFAST:rc-3.5.3 Feb 19, 2024
19 of 38 checks passed
@deslaughter deslaughter deleted the b/GHactions_node16_deprecate branch February 19, 2024 14:16
@andrew-platt andrew-platt mentioned this pull request Mar 26, 2024
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants