Bug: BeamDyn Initial Strain and Linearization #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ab42564.
The previous initial strain fix caused bad linearization results (and likely didn't fix the issue in the correct way). The new one replaces RR0 with R*x0' which is what OpenTurbine is using to avoid the mismatch that caused initial strain.
andrew-platt
approved these changes
Mar 12, 2024
This fix was unintentionally removed when reverting the initial strain fix.
andrew-platt
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready to merge.
Feature or improvement description
This PR reverts the BeamDyn initial strain fix that was merged last year and released in OpenFAST
v3.5.1. It then implements a new fix for the initial strain based on the GEBT implemented in OpenTurbine.Impacted areas of the software
BeamDyn
5MW_Land_BD_Linear Regression test
5MW_Land_BD_Linear_Aero Regression Test
Additional supporting information
The previous fix for the initial strain caused issues with linearization for the IEA 15MW turbine which has a curved blade. The full reason for this is not understood; however, a substitute fix was readily available and easy to implement once the previous fix was reverted.
Test results, if applicable
This PR changes the
5MW_Land_BD_Linearand5MW_Land_BD_Linear_Aeroregression test results which were generated after the previous initial strain fix was implemented.